Last modified: 2014-06-23 19:09:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68935, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 66935 - AbuseFilterParserTest failure under HHVM


Summary:	AbuseFilterParserTest failure under HHVM

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	AbuseFilter (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://github.com/facebook/hhvm/issu...
Whiteboard:
Keywords:	hhvm

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-22 03:11 UTC by Ori Livneh
Modified:	2014-06-23 19:09 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2014-06-22 03:11:22 UTC

This test passes with Zend.

1) AbuseFilterParserTest::testParser with data set #13 ('like', '"foobér" like "foob?r" & "quux" matches "qu*x"', true)
Running parser test like
Failed asserting that false matches expected true.

/srv/mediawiki/extensions/AbuseFilter/tests/phpunit/parserTest.php:51
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42

Comment 1 Ori Livneh 2014-06-23 02:55:19 UTC

Minimal case:

  $ hhvm --php -r "var_dump(fnmatch('foob?r', 'foobér'));"
  bool(false)
  $ php5 -r "var_dump(fnmatch('foob?r', 'foobér'));"
  bool(true)

Comment 2 Ori Livneh 2014-06-23 19:09:47 UTC

Fixed by https://gerrit.wikimedia.org/r/#/c/141483/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links