Last modified: 2014-07-22 14:33:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68967, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66967 - Special:ContentTranslation inserts source links as target
Special:ContentTranslation inserts source links as target
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ContentTranslation (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Amir E. Aharoni
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-23 05:44 UTC by Amir E. Aharoni
Modified: 2014-07-22 14:33 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2014-06-23 05:44:49 UTC
If a target link doesn't exist, the source link may be inserted incorrectly.

This can be fixed by removing `|| page.title` in ext.cx.tools.link.js line 112, because if there's no page.langlinks[ 0 ][ '*' ], then there's probably no target link to insert, but then the problem is that redirects are not handled correctly: linkPairs is indexed by the real target article, while the adaptations parameter in apply() is looked up by the href, which is the name of the redirect.
Comment 1 Gerrit Notification Bot 2014-06-23 05:45:43 UTC
Change 141379 had a related patch set uploaded by Amire80:
Don't insert source title if there's no target link

https://gerrit.wikimedia.org/r/141379
Comment 2 Gerrit Notification Bot 2014-07-01 14:45:50 UTC
Change 141379 abandoned by Amire80:
Don't insert source title if there's no target link

Reason:
the meaningful part was merged in another patch.

https://gerrit.wikimedia.org/r/141379
Comment 3 Amir E. Aharoni 2014-07-16 16:23:38 UTC
Patch: https://gerrit.wikimedia.org/r/#/c/146802/
Comment 4 Santhosh Thottingal 2014-07-22 14:33:55 UTC
https://gerrit.wikimedia.org/r/#/c/146802/ merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links