Last modified: 2014-09-17 01:12:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T68986, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 66986 - GlobalVarConfig throws exceptions for globals with null value
GlobalVarConfig throws exceptions for globals with null value
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Configuration (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: 1.23.x release
Assigned To: Brad Jorsch
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-23 17:05 UTC by Brad Jorsch
Modified: 2014-09-17 01:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
legoktm.wikipedia: Backport_to_Stable+
bjorsch: Backport_WMF+


Attachments

Description Brad Jorsch 2014-06-23 17:05:13 UTC
For example, the default value for $wgRightsPage is null. And https://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&siprop=rightsinfo is throwing an exception when it isn't overridden.

Patch to follow momentarily.
Comment 1 Gerrit Notification Bot 2014-06-23 17:05:52 UTC
Change 141468 had a related patch set uploaded by Anomie:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/141468
Comment 2 Gerrit Notification Bot 2014-06-23 19:08:24 UTC
Change 141468 merged by jenkins-bot:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/141468
Comment 3 Umherirrender 2014-06-23 19:11:35 UTC
was successfully merged
Comment 4 Brad Jorsch 2014-06-23 19:13:05 UTC
Should backport this, no reason to let stuff be broken for a week until wmf11 rolls out.

I've scheduled it for the Tuesday morning SWAT, but if someone wants to do it this evening feel free.
Comment 5 Gerrit Notification Bot 2014-06-24 13:08:06 UTC
Change 141680 had a related patch set uploaded by Anomie:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/141680
Comment 6 Gerrit Notification Bot 2014-06-24 15:01:03 UTC
Change 141680 merged by jenkins-bot:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/141680
Comment 7 Brad Jorsch 2014-06-24 15:03:53 UTC
Backported.
Comment 8 Gerrit Notification Bot 2014-09-16 16:53:02 UTC
Change 160688 had a related patch set uploaded by Legoktm:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/160688
Comment 9 Gerrit Notification Bot 2014-09-17 01:11:53 UTC
Change 160688 merged by Legoktm:
GlobalVarConfig shouldn't throw exceptions for null-valued config settings

https://gerrit.wikimedia.org/r/160688
Comment 10 Kunal Mehta (Legoktm) 2014-09-17 01:12:27 UTC
Will also be included in the next 1.23.x release.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links