Last modified: 2014-07-10 20:19:50 UTC
Created attachment 15702 [details] Double tap required If you open VE on mobile and want to edit an existing reference, you need to tap it twice. This is really hard, especially given that the tap target is quite small (which is a separate issue). Tested and recorder in iOS Safari 7.1.1. Does not happen on Chrome for Android (just a single tap needed there).
Ignore wrong positioning of mobile context (second toolbar), it's fixed now. To actually see the context though you need those patches: https://gerrit.wikimedia.org/r/#/c/141085/ https://gerrit.wikimedia.org/r/#/c/141087/
Pushing to Ed because it appears to be a shield/highlight issue.
Isn't this fixed then (comment 1)?
(In reply to Ed Sanders from comment #3) > Isn't this fixed then (comment 1)? … no? Comment 1 says that the context being useless ("the tap target is quite small") is fixed by some other patches and you should ignore. Comment 0 is mostly about "If you open VE on mobile and want to edit an existing reference, you need to tap it twice." which remains a bug.
Looks like it's fixed by bug 67063's fix.
This bug did not get resolved by Ed's fix. The issue here is, the first tap is showing a lighter highlight which is equivalent to the hover effect in the desktop and for the second tap it is actually selecting that node. This is why, even if you have selected a reference (with two tap) , you can still semi-select another node (with lighter highlight)at the same time For mobile, it should require one single tap to select any reference/image etc.
Change 142839 had a related patch set uploaded by Esanders: Select highlights on touchend event https://gerrit.wikimedia.org/r/142839
Change 142839 merged by jenkins-bot: Select highlights on touchend event https://gerrit.wikimedia.org/r/142839
Verified the fix in Betalabs.
Verified the fix in test2
Verified the fix in production
