Last modified: 2014-07-10 20:20:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69002, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67002 - VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari
VisualEditor Mobile: Second tap on a reference navigates away from (closes) V...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-23 21:38 UTC by Juliusz Gonera
Modified: 2014-07-10 20:20 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Editor closes (3.38 MB, video/quicktime)
2014-06-23 21:38 UTC, Juliusz Gonera
Details
Editor shows confirmation dialog (5.63 MB, video/quicktime)
2014-06-23 21:38 UTC, Juliusz Gonera
Details

Description Juliusz Gonera 2014-06-23 21:38:07 UTC
As mentioned in bug 66999 references require two taps on iOS Safari. Often, the first tap results in a lighter "semi-selection" appearing a bit below the actual reference. When that happens, second tap on the reference suddenly closes the editor (first video).

The editor doesn't crash though, somehow cancel action is triggered. If you have unsaved changes, you'll see a dialog asking you if you want to abandon the edit (second video).

Tested and recorder in iOS Safari 7.1.1. Does not happen on Chrome for Android.
Comment 1 Juliusz Gonera 2014-06-23 21:38:32 UTC
Created attachment 15703 [details]
Editor closes
Comment 2 Juliusz Gonera 2014-06-23 21:38:51 UTC
Created attachment 15704 [details]
Editor shows confirmation dialog
Comment 3 James Forrester 2014-06-24 01:24:49 UTC
Pushing to Ed because it appears to be a shield/highlight issue.
Comment 4 James Forrester 2014-06-26 18:11:13 UTC
Probably (?) fixed by the fix to bug 67063.
Comment 5 Rummana Yasmeen 2014-06-27 18:42:32 UTC
This bug did not get fixed by :

Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260
Comment 6 Rummana Yasmeen 2014-06-27 18:58:42 UTC
For images, second tap on it opens up the image which might also be the effect of this same bug.
Comment 7 Rummana Yasmeen 2014-06-28 00:12:24 UTC
Ok, the behavior got slightly changed here, it wont close the VE now if your second tap on the same reference follows right after your first tap

To reproduce it now you need to first tap on a reference say [1], then tap on another reference [2], then go back and tap [1].Now it will close the VE .
Comment 8 Rummana Yasmeen 2014-06-30 20:28:41 UTC
This seems to got fixed by:

Select highlights on touchend event

https://gerrit.wikimedia.org/r/142839
Comment 9 Rummana Yasmeen 2014-06-30 20:28:55 UTC
Verified the fix in Betalabs
Comment 10 Rummana Yasmeen 2014-07-08 00:23:16 UTC
Verified the fix in test2
Comment 11 Rummana Yasmeen 2014-07-10 20:20:46 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links