Last modified: 2014-08-20 23:51:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69007, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67007 - <table> in fosterable position in another <table> - tidy (html4) vs html5 treebuilding differences
<table> in fosterable position in another <table> - tidy (html4) vs html5 tre...
Status: REOPENED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-23 22:30 UTC by Gabriel Wicke
Modified: 2014-08-20 23:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2014-06-23 22:30:49 UTC
Search for 'SPAZI TRA LE COLONNE' in

http://parsoid-lb.eqiad.wikimedia.org/itwiki/Pagina_principale?oldid=65679446

Apparently a table row is not recognized as such.
Comment 1 ssastry 2014-06-23 22:38:30 UTC
Interesting how these come in spurts .. Arlo is currently working on https://gerrit.wikimedia.org/r/#/c/141587/ which is for bug 66686

*** This bug has been marked as a duplicate of bug 66686 ***
Comment 2 Gabriel Wicke 2014-06-23 22:39:46 UTC
The spurt is Nemo_bis in #mediawiki reporting issues ;)
Comment 3 ssastry 2014-06-23 22:42:02 UTC
I meant: the bug has been around for ages, and in the span of a week, it is encountered twice. :)
Comment 4 ssastry 2014-06-23 22:54:06 UTC
Sorry, not a dupe .. it looked very similar to the other issue with empty comment lines and unrecognized table cells following that.
Comment 5 Arlo Breault 2014-06-24 20:06:47 UTC
I'm not sure if editing the page is the right thing to do here, but most of the content is being placed in a fosterable position:

{| cellpadding="2" cellspacing="5" style="width:100%; vertical-align:top; background:transparent;"
<!-- ==============VETRINA ================ -->
<div id="mf-viv" title="Novità in Vetrina">
{{FinestraHome7
 |titolo= Vetrina
 |logosfondo= Bluebg_rounded_croped.png
 |logo= HSUtvald.svg
 |px= 38
 |contenuto=
{{Pagina principale/Vetrina}}
}}
</div>
Comment 6 Gabriel Wicke 2014-06-24 20:44:23 UTC
This wikitext fix would avoid the issue:

https://it.wikipedia.org/w/index.php?title=Utente%
3AGWicke%2Fmainpage&diff=66666719&oldid=66666189

I agree that this seems to be broken wikitext, which tidy probably handles with a special heuristic.
Comment 7 Gabriel Wicke 2014-06-24 20:44:50 UTC
Parsoid output after fix: http://parsoid-lb.eqiad.wikimedia.org/itwiki/Utente%3AGWicke%2Fmainpage?oldid=66666719
Comment 8 Gabriel Wicke 2014-06-24 21:07:25 UTC
I'm still not sure why Parsoid renders this broken wikitext differently from PHP. A simple test case at https://www.mediawiki.org/wiki/User:GWicke/Test/FosterParent shows PHP+tidy fostering as well.

Should we keep this open for now until we have an idea if this is a really rare issue, or something that matters in practice & should be addressed?
Comment 9 Arlo Breault 2014-06-24 21:07:52 UTC
Here's another test case,

{|
<table></table>
|<!-- comment -->
}}
Comment 10 Arlo Breault 2014-06-24 21:09:12 UTC
sorry, that should end in |}
Comment 11 Arlo Breault 2014-06-24 22:39:21 UTC
The difference seems to be in how tables in fosterable position are resolved.

wikitext:

{| cellpadding="1"
<table id="2">
<td>text</td>
</table>
|<!-- comment -->
| some more text
|}


php:

<table cellpadding="1">
<tr>
<td>text</td>
</tr>
</table>
<table>
<tr>
<td></td>
<td>some more text</td>
</tr>
</table>

parsoid:

<table cellpadding="1"></table>
<table id="2">
<tr>
<td>text</td>
</tr>
</table>
|<!-- comment -->
| some more text
Comment 12 ssastry 2014-08-20 23:49:47 UTC
Parsoid's behavior which derives from HTML5 treebuilding seems consistent with browser behavior on the following html.

<table>
<table>
<td>text</td>
</table>
<td>some more text</td>
</table>

That html is rendered as follows in FF:

<table></table>
<table>
<td>text</td>
</table>
some more text

So, this is one more instance of html4 tidy vs html5 tree building behavior differences.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links