Last modified: 2014-07-16 16:24:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69038, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67038 - EditPreviewFragment doesn't handle errors
EditPreviewFragment doesn't handle errors
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Android App (Other open bugs)
Alpha
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-24 17:40 UTC by Dmitry Brant
Modified: 2014-07-16 16:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dmitry Brant 2014-06-24 17:40:19 UTC 
We instantiate an EditPreviewTask without having an onCatch function.

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7609600
Comment 1 Gerrit Notification Bot 2014-06-24 20:21:30 UTC 
Change 141816 had a related patch set uploaded by Dbrant:
Implement (simple) error handling when fetching preview.

https://gerrit.wikimedia.org/r/141816
Comment 2 Gerrit Notification Bot 2014-06-24 23:10:47 UTC 
Change 141816 merged by jenkins-bot:
Implement (simple) error handling when fetching preview.

https://gerrit.wikimedia.org/r/141816
Comment 3 Alex Monk 2014-07-13 11:59:47 UTC 
Is this done now? Should https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7666254 be occurring or not (I'm still not yet clear on which code has been sent to Google Play for download)
Comment 4 Alex Monk 2014-07-13 12:32:28 UTC 
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7666254 too. Also not sure these are to do with edit previews, so might be a different bug.
Comment 5 Dmitry Brant 2014-07-16 15:54:20 UTC 
I've created Bug 68109 to take care of the report in Comment 4.
Comment 6 Alex Monk 2014-07-16 15:58:23 UTC 
Okay, is this fixed now then?
Comment 7 Dmitry Brant 2014-07-16 16:12:10 UTC 
Yes, it is. (although not in the public release yet)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links