Last modified: 2014-07-01 18:52:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69041, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 67041 - $wgUsersNotifiedOnAllChanges sends mail even if already sent via watchlist


Summary:	$wgUsersNotifiedOnAllChanges sends mail even if already sent via watchlist

Status:	PATCH_TO_REVIEW

Product:	MediaWiki
Classification:	Unclassified
Component:	Watchlist (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Rohan Rawat

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-06-24 18:06 UTC by Greg Sabino Mullane
Modified:	2014-07-01 18:52 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Prevent duplicate emails from being sent (1.35 KB, patch) 2014-06-24 18:06 UTC, Greg Sabino Mullane	Details
Add an attachment (proposed patch, testcase, etc.)

Description Greg Sabino Mullane 2014-06-24 18:06:50 UTC

Created attachment 15714 [details]
Prevent duplicate emails from being sent

If you have a page in your watchlist, and you are in the wgUsersNotifiedOnAllChanges array, you receive two emails about the changed page.

Comment 1 Greg Sabino Mullane 2014-06-24 20:16:58 UTC

Of course, should use getName() or similar as the keys, not the User object.

Comment 2 Andre Klapper 2014-06-25 09:12:04 UTC

Hi Greg! Thanks for the patch!
You are very welcome to use Wikimedia Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit the patch as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/

Comment 3 Gerrit Notification Bot 2014-07-01 18:52:24 UTC

Change 143373 had a related patch set uploaded by Rohan013:
Checks for each user in the $wgUsersNotifiedOnAllChange list before sending the mail

https://gerrit.wikimedia.org/r/143373

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links