Last modified: 2014-09-18 18:51:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69047, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67047 - VisualEditor: Image should not change size when going from read to edit
VisualEditor: Image should not change size when going from read to edit
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-24 19:12 UTC by Jared Zimmerman (WMF)
Modified: 2014-09-18 18:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jared Zimmerman (WMF) 2014-06-24 19:12:26 UTC
When editing "default size" in mw prefs is not honored
Comment 1 James Forrester 2014-06-26 00:14:12 UTC
This is verging on a WONTFIX; we actively don't want people resizing images to look "right" for them, which this would encourage.
Comment 2 Jared Zimmerman (WMF) 2014-06-26 01:25:50 UTC
I think i might have been unclear on this one. 

The gist is "Image should not change size when going from read to edit"

there are many possible fixes, but the one that seemed simplest was, for images which are at "default" size, look at users preference for what size "default" is and display them at that size when in edit mode.

there might be other options, but the bug is that they change, size at all.
Comment 3 James Forrester 2014-06-26 01:27:49 UTC
(In reply to Jared Zimmerman (WMF) from comment #2)
> I think i might have been unclear on this one. 
> 
> The gist is "Image should not change size when going from read to edit"
> 
> there are many possible fixes, but the one that seemed simplest was, for
> images which are at "default" size, look at users preference for what size
> "default" is and display them at that size when in edit mode.

And as I said, we have intentionally chosen not to do this.

> there might be other options, but the bug is that they change, size at all.

The simplest "fix" to this issue is to remove the user preference. But you probably don't want that.
Comment 4 Jared Zimmerman (WMF) 2014-07-21 18:40:43 UTC
I think I might be being unclear with the request…


As a user who sets my thumbnail preference to (120/180/220/250/300/etc)px while in visual editor I see "default sized" thumbnails display as (120/180/220/250/300/etc)px depending on my preference. 

I'm not sure I understand your point "we actively don't want people resizing images to look "right" for them, which this would encourage." which is the exact opposite of what this would do, if the images LOOK right when i get to VE then I'm much less likely to go on a resizing spree.
Comment 5 Jared Zimmerman (WMF) 2014-09-18 18:51:54 UTC
I'd like to revisit this, the current behavior is actively against the WYSIWYG model established in VE. I'm still not understanding the argument against this. If images are the same size both in read and edit mode, how will this contribute to editors wanted to resize them to "look right for them" if they already look correct? if anything this seems like it would lessen the desire to fiddle with image sizes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links