Last modified: 2014-07-10 20:22:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69063, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67063 - VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS
VisualEditor Mobile: The highlight for images are appearing in wrong position...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Mobile (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-25 00:36 UTC by Rummana Yasmeen
Modified: 2014-07-10 20:22 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: iOS 7.x
Assignee Huggle Beta Tester: ---


Attachments
Screenshot-1 (51.74 KB, image/jpeg)
2014-06-25 00:36 UTC, Rummana Yasmeen
Details
Screenshot-2 (30.70 KB, image/jpeg)
2014-06-25 00:36 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-06-25 00:36:16 UTC
Created attachment 15725 [details]
Screenshot-1

Steps to reproduce:

1.Open a page with safari in any iOS device which contains image in it
2.Now tap on the image to select it

Observed Result:
The highlight for the image is appearing much below the image 

See the screenshots attached
Comment 1 Rummana Yasmeen 2014-06-25 00:36:50 UTC
Created attachment 15726 [details]
Screenshot-2
Comment 2 Ed Sanders 2014-06-26 14:05:36 UTC
In every browser except iOS7 getClientRects is relative to the viewport. In iOS7 it is relative to document. Thanks Apple.
Comment 3 James Forrester 2014-06-26 14:09:50 UTC
Want to write up a bug report for Apple?
Comment 4 Gerrit Notification Bot 2014-06-26 15:58:27 UTC
Change 142260 had a related patch set uploaded by Esanders:
Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260
Comment 5 Gerrit Notification Bot 2014-06-26 16:56:33 UTC
Change 142260 merged by jenkins-bot:
FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260
Comment 6 Rummana Yasmeen 2014-06-27 18:41:28 UTC
The highlight for images appearing in wrong position is now fixed ! :)
However the tapping on link or image redirecting to the link target or image file page and second tap on reference closing the VE is still there.Therefore, I suppose the following bugs are not related:

https://bugzilla.wikimedia.org/show_bug.cgi?id=65326
https://bugzilla.wikimedia.org/show_bug.cgi?id=67002
Comment 7 Rummana Yasmeen 2014-06-30 20:43:17 UTC
Verified the fix in Betalabs.
Comment 8 Rummana Yasmeen 2014-07-08 00:02:00 UTC
Verified the fix in test2
Comment 9 Rummana Yasmeen 2014-07-10 20:22:05 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links