Last modified: 2014-07-10 18:54:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69105, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67105 - In desktop mode of Minerva, section toggling is broken. It should probably be removed.
In desktop mode of Minerva, section toggling is broken. It should probably be...
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-25 22:18 UTC by Ryan Kaldari
Modified: 2014-07-10 18:54 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-06-25 22:18:15 UTC 
See:
https://en.wikipedia.org/w/index.php?title=Textile_manufacturing&useskin=minerva

Since all sections are open by default in Minerva's desktop mode, clicking the open section toggler doesn't do anything (nor does closing a section). We should probably just not load the section toggling code in desktop mode.
Comment 1 Bingle 2014-06-25 22:20:20 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Kg8RdCmT
Comment 2 Ryan Kaldari 2014-06-25 22:25:02 UTC 
This is actually due to the fact that we don't have sections in the desktop DOM (since we don't apply MobileFormatter). Since we don't really need section toggling on desktop, Max agrees it makes more sense to just remove the toggling feature in desktop rather than introducing sections.
Comment 3 Gerrit Notification Bot 2014-06-30 18:16:02 UTC 
Change 143062 had a related patch set uploaded by Florianschmidtwelzow:
Minerva Desktop: Remove toggling and fix TOC

https://gerrit.wikimedia.org/r/143062
Comment 4 Florian 2014-06-30 22:50:48 UTC 
Set to new again, after split PS in two commits (see comment from kaldari) :)
Comment 5 Gerrit Notification Bot 2014-06-30 23:08:51 UTC 
Change 143191 had a related patch set uploaded by Florianschmidtwelzow:
Minerva Desktop: Remove toggling sections

https://gerrit.wikimedia.org/r/143191
Comment 6 Gerrit Notification Bot 2014-07-10 18:50:49 UTC 
Change 143191 merged by jenkins-bot:
Minerva Desktop: Remove toggling sections

https://gerrit.wikimedia.org/r/143191
Comment 7 Florian 2014-07-10 18:54:04 UTC 
both merged, set as resolved :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links