Last modified: 2014-08-23 01:19:00 UTC
Created attachment 15749 [details] Insert image dialog box Align and Format fields empty Setup- none. Steps to Reproduce- 1>Select “Create Source” tab to use Wikitext Editor. 2>Click on the “Embedded File” icon on the toolbar at the top of the editor pane, to insert an image file. 3> The “Insert File” dialog opens. Enter the Filename, Caption, size. Notice that Align is by default set to “(default)” and Format is set to “Thumbnail” . 4> Now click on “Insert” button. 5> Text in the format [[File: filename |thumbnail| caption]] is entered and highlighted in the editor pane. 6> Move to the next line by hitting enter key. And while the cursor is still in the newline click on the “Embedded File” icon again. 7> Notice this time the Align and Format dropdowns are not set to any values. 8> Clicking on the “Insert” button does nothing and no error is thrown. 9> Now enter the Filename, Caption, size and click on “Insert” button, no error is thrown again. Actual Result- The second time the Embedded File icon is accessed in the wikitext editor ,the Align and Format dropdowns are not set to any values. See attached screenshot WE_Insert_Image.png. Expected Result- Every time the Embedded File icon is accessed in the wikitext editor , the Align and Format dropdowns should be set to their default values. Also, the required fields in the Insert Image dialog box should be marked as such and the input fields should be validated (see Bug 38823 ).
Confirming on test2 with Firefox 30
Change 154123 had a related patch set uploaded by TheDJ: Dialogs: Reset values of file insertion dialog properly https://gerrit.wikimedia.org/r/154123
Change 154123 merged by jenkins-bot: Dialogs: Reset values of file insertion dialog properly https://gerrit.wikimedia.org/r/154123
So this should be fixed now.