Last modified: 2014-08-23 01:19:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69111, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67111 - In Insert Image dialog box the Align and Format settings are not set to any values
In Insert Image dialog box the Align and Format settings are not set to any v...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Derk-Jan Hartman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-26 05:17 UTC by Ritu Swain
Modified: 2014-08-23 01:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Insert image dialog box Align and Format fields empty (13.78 KB, image/png)
2014-06-26 05:17 UTC, Ritu Swain
Details

Description Ritu Swain 2014-06-26 05:17:40 UTC
Created attachment 15749 [details]
Insert image dialog box Align and Format fields empty

Setup- none.

Steps to Reproduce-
1>Select “Create Source” tab to use Wikitext Editor.
2>Click on the “Embedded File” icon on the toolbar at the top of the editor pane, to insert an image file.
3> The “Insert  File” dialog opens. Enter the Filename, Caption, size. Notice that Align is by default set to “(default)”  and Format is set to “Thumbnail” .
4> Now click on “Insert” button. 
5> Text in the format [[File:  filename  |thumbnail| caption]] is entered and highlighted in the editor pane.
6> Move to the next line by hitting enter key. And while the cursor is still in the newline click on the “Embedded File” icon again.
7> Notice this time the Align and Format dropdowns are not set to any values.
8> Clicking on the “Insert” button does nothing and no error is thrown.
9> Now enter the Filename, Caption, size and click on “Insert” button, no error is thrown again.

Actual Result- The second time the Embedded File icon is accessed in the wikitext editor ,the Align and Format dropdowns are not set to any values. See  attached screenshot WE_Insert_Image.png.

Expected Result- Every time the Embedded File icon is accessed in the wikitext editor , the Align and Format dropdowns  should be set to  their default values.
Also, the required fields in the Insert Image dialog box should be marked as such and the input fields should be validated (see Bug 38823 ).
Comment 1 Andre Klapper 2014-07-11 12:20:47 UTC
Confirming on test2 with Firefox 30
Comment 2 Gerrit Notification Bot 2014-08-14 19:59:09 UTC
Change 154123 had a related patch set uploaded by TheDJ:
Dialogs: Reset values of file insertion dialog properly

https://gerrit.wikimedia.org/r/154123
Comment 3 Gerrit Notification Bot 2014-08-23 01:17:32 UTC
Change 154123 merged by jenkins-bot:
Dialogs: Reset values of file insertion dialog properly

https://gerrit.wikimedia.org/r/154123
Comment 4 Alex Monk 2014-08-23 01:19:00 UTC
So this should be fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links