Last modified: 2014-06-30 23:49:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69169, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67169 - VisualEditor: Text-only GeneratedContentNode rerenderings aren't highlighted correctly
VisualEditor: Text-only GeneratedContentNode rerenderings aren't highlighted ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Low minor
: VE-deploy-2014-07-03
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-26 23:19 UTC by Roan Kattouw
Modified: 2014-06-30 23:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-06-26 23:19:06 UTC 
1. Create a page with {{echo|foo}} in the text somewhere
2. Observe that the word "foo" is highlighted and clickable and all those good things
3. Inspect "foo", and change the parameter to "bar"
4. Click the rerendering

Note that there is no highlight, you're able to select parts of the word (!), it's not inspectable, etc.
Comment 1 Ed Sanders 2014-06-27 00:07:10 UTC 
What about after https://gerrit.wikimedia.org/r/140439 ?
Comment 2 Gerrit Notification Bot 2014-06-27 22:04:54 UTC 
Change 140439 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Remove generated content node wrappers

https://gerrit.wikimedia.org/r/140439
Comment 3 Ed Sanders 2014-06-27 22:05:11 UTC 
Confirmed fix
Comment 4 Gerrit Notification Bot 2014-06-30 23:17:53 UTC 
Change 140439 merged by jenkins-bot:
[BREAKING CHANGE] Remove generated content node wrappers

https://gerrit.wikimedia.org/r/140439
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links