Last modified: 2014-07-16 22:57:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69177, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67177 - VisualEditor: Typing when a focusable node is selected should do nothing
VisualEditor: Typing when a focusable node is selected should do nothing
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-07-17
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-27 00:34 UTC by James Forrester
Modified: 2014-07-16 22:57 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-06-27 00:34:40 UTC
Correct outcome:

* Select an inline image (or a reference or alien or…).
* Press "a".

Observe that the reference has been deleted, and an 'a' is in its place.


Bad outcome;

* Select a block image (or block template or…).
* Press "a".

Observe that the block image has not been deleted, and the 'a' is not in its place (and no transaction has occurred).
Comment 1 Ed Sanders 2014-07-16 16:49:54 UTC
Real world comparison:
* Open/Libre office: typing while selecting an image does nothing
* Google docs: typing replaces the image

I think it's a rare workflow where you select a block image and want to replace it with a paragraph, and if you really do you can just press backspace/delete. We have taken other measures to prevent the accidental deletion of focusable nodes elsewhere (e.g. adjacent backspace only selects) so this seems like a logical extension.
Comment 2 Gerrit Notification Bot 2014-07-16 16:50:11 UTC
Change 146808 had a related patch set uploaded by Esanders:
Prevent deletion of focusable nodes by typing

https://gerrit.wikimedia.org/r/146808
Comment 3 Gerrit Notification Bot 2014-07-16 22:51:15 UTC
Change 146808 merged by jenkins-bot:
Prevent deletion of focusable nodes by typing

https://gerrit.wikimedia.org/r/146808

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links