Last modified: 2014-11-17 21:36:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69214, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67214 - Support newer puppet (3.6.x)
Support newer puppet (3.6.x)
Status: UNCONFIRMED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-27 20:57 UTC by Mark A. Hershberger
Modified: 2014-11-17 21:36 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2014-06-27 20:57:50 UTC
When trying to run "vagrant provision" against the latest puppet (3.6.2) I get the following output:


 Warning: The use of 'import' is deprecated at
               /tmp/vagrant-puppet-1/manifests/site.pp:9.
               See http://links.puppetlabs.com/puppet-import-deprecation
   (at grammar.ra:610:in `_reduce_190')
 Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults
 Error: Failed to parse template mediawiki/mediawiki-apache-site.erb:
   Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/util/package.rb
   Line: 4
   Detail: private method `scan' called for nil:NilClass
  at /tmp/vagrant-puppet-1/modules-0/mediawiki/manifests/apache.pp:17 on node mediawiki-vagrant.dev
 Error: Failed to parse template mediawiki/mediawiki-apache-site.erb:
   Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/util/package.rb
   Line: 4
   Detail: private method `scan' called for nil:NilClass
  at /tmp/vagrant-puppet-1/modules-0/mediawiki/manifests/apache.pp:17 on node mediawiki-vagrant.dev
Comment 1 Bryan Davis 2014-07-10 16:20:47 UTC
Can you retry with the latest mw-vagrant version? We are running Ubuntu 14.04 now with Puppet 3.4.3 in the default image. Ori landed quite a few Puppet changes to make this possible since you initially reported the bug.
Comment 2 Tyler Romeo 2014-07-26 04:07:50 UTC
FYI: http://docs.puppetlabs.com/puppet/latest/reference/lang_import.html

The import statement will be removed in Puppet 4.
Comment 3 Bryan Davis 2014-07-26 04:15:28 UTC
(In reply to Tyler Romeo from comment #2)
> FYI: http://docs.puppetlabs.com/puppet/latest/reference/lang_import.html
> 
> The import statement will be removed in Puppet 4.

Acknowledged. The Ubuntu 14.04 LTS release shipped with Puppet 3.x, so I would expect we must become concerned with Puppet 4.x compatibility on or about April 2016.
Comment 4 Tyler Romeo 2014-07-26 04:17:29 UTC
Indeed, but there should probably be some sort of migration plan, considering that the plugin currently relies on the import statement in order to add roles.
Comment 5 Bryan Davis 2014-07-26 04:51:52 UTC
(In reply to Tyler Romeo from comment #4)
> Indeed, but there should probably be some sort of migration plan,
> considering that the plugin currently relies on the import statement in
> order to add roles.

One way forward for this would be to shift to using the hiera_include() feature which allows a hierarchy of yaml and/or json configuration files to declare a list of puppet classes which should be applied to the active node. It will take some effort, but with the combination of well constructed modules and hiera's configuration selection mechanisms we should be able to eliminate "role" classes which seek to provide customization of more general features. It could be done in the most brutish manner today by moving the current roles collection to a module and turning the other non-module configuration into modules that can be discovered by the puppet autoloading mechanism. 

In my personal opinion, MediaWiki-Vagrant should seek to track the work in this direction that is currently in the planning stage for the operations/puppet.git repository with an optimistic long term goal of abandoning much of our custom puppet implementation for utilization of operations/puppet.git directly. We will probably end up with a few odds and ends which are MediaWiki-Vagrant specific, but hopefully by the time we get close to convergence we will also see a reasonable method to augment the base classes for our environment. The desire to unify production, beta and labs projects within operations/puppet.git gives me hope that we will have enough eyes and fingers dedicated to the task to make significant progress towards this ambitious goal.
Comment 6 Gerrit Notification Bot 2014-08-18 02:52:13 UTC
Change 153420 had a related patch set uploaded by BryanDavis:
Migrate roles to hiera_include

https://gerrit.wikimedia.org/r/153420
Comment 7 Gerrit Notification Bot 2014-08-18 22:11:11 UTC
Change 153420 merged by Dduvall:
Migrate roles to hiera_include

https://gerrit.wikimedia.org/r/153420
Comment 8 Bryan Davis 2014-08-18 23:52:40 UTC
(In reply to Mark A. Hershberger from comment #0)
>  Warning: The use of 'import' is deprecated at
>                /tmp/vagrant-puppet-1/manifests/site.pp:9.
>                See http://links.puppetlabs.com/puppet-import-deprecation
>    (at grammar.ra:610:in `_reduce_190')

Fixed by https://gerrit.wikimedia.org/r/153420

We are using hiera_include() and properly pathed modules for everything now.

>  Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults

Fixed in https://gerrit.wikimedia.org/r/#/c/144071/

>  Error: Failed to parse template mediawiki/mediawiki-apache-site.erb:
>    Filepath: /usr/lib/ruby/site_ruby/1.8/puppet/util/package.rb
>    Line: 4
>    Detail: private method `scan' called for nil:NilClass
>   at /tmp/vagrant-puppet-1/modules-0/mediawiki/manifests/apache.pp:17 on
> node mediawiki-vagrant.dev

Not sure about this one, but the template that triggered this error has had fairly significant changes since the bug was reported.
Comment 9 Bryan Davis 2014-08-18 23:57:45 UTC
Mark, I'd appreciate it if you could retest this now and see if we are good to close.
Comment 10 Andre Klapper 2014-10-16 13:03:41 UTC
hexmode: Please answer comment 9.
Comment 11 Andre Klapper 2014-11-15 12:04:12 UTC
hexmode: Please answer comment 9.
Comment 12 Bryan Davis 2014-11-17 21:36:17 UTC
Bulk unassigning bugs from Ori.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links