Last modified: 2014-07-29 18:31:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69226, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67226 - Flow front-end: moderation dialog issues
Flow front-end: moderation dialog issues
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-28 00:13 UTC by spage
Modified: 2014-07-29 18:31 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-06-28 00:13:09 UTC
1. Login to a wiki running new front end.
2. Click post's action menu, choose Hide.

a) The title used to be "Hide post?" (flow-moderation-title-hide-post), now it mistakenly reuses the button "Hide" text (flow-post-action-hide-post).
b) The introductory text "Please explain why you're hiding this post." (flow-moderation-intro-hide-post) isn't shown.
c) There's no placeholder text "Enter your reason here" (flow-moderation-reason-placeholder) in the textarea.
d) After submitting the form you used to get a transient mw.notify() "toaster" display "The post was successfully hidden.\n{{GENDER:$2|Consider}} giving $1 feedback on this post." (flow-moderation-confirmation-hide-post)

In a quick chat May Galloway suggested:
* Fix a)
* Drop the introductory text b), and turn it into placeholder text c) specific to each moderation action (e.g. flow-moderation-placeholder-hide-post).
* Probably revive d), see https://trello.com/c/lSIqjAdI but note bug 62612.
Comment 1 Danny Horn 2014-06-30 17:18:10 UTC
Card for fixing wrong "Hide post?" message: https://trello.com/c/LFNpW1BX

Card for redesigning the moderation dialog: https://trello.com/c/OLnPx7M4
Comment 2 Gerrit Notification Bot 2014-07-16 00:12:19 UTC
Change 146653 had a related patch set uploaded by EBernhardson:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/146653
Comment 3 Gerrit Notification Bot 2014-07-18 18:53:04 UTC
Change 146653 merged by jenkins-bot:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/146653
Comment 4 Gerrit Notification Bot 2014-07-22 20:19:21 UTC
Change 148451 had a related patch set uploaded by EBernhardson:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/148451
Comment 5 Gerrit Notification Bot 2014-07-22 22:15:38 UTC
Change 148451 merged by jenkins-bot:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/148451
Comment 6 spage 2014-07-29 18:31:08 UTC
The messages were improved.

Still no d) "toaster" display after moderating "The post was successfully hidden.\n{{GENDER:$2|Consider}} giving $1 feedback on this post."

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links