Last modified: 2014-07-01 22:46:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69235, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67235 - Flow front-end: link to post stopped highlighting it with green left border
Flow front-end: link to post stopped highlighting it with green left border
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.beta.wmflabs.org/...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-28 03:58 UTC by spage
Modified: 2014-07-01 22:46 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-06-28 03:58:46 UTC 
Gerrit change #141623 revived this feature in the front-end rewrite, but the CSS changes in Gerrit change #141638 "Restrict indentation of edit forms and previews" broke it again.

The FlowBoardComponent code that notices #flow-post-rxgfcovteg07a904 runs. it adds class="flow-post-highlighted" to a plausible div, in Firebug the child .flow-post-main gets flow-border-left styled green, and then calls .conditionalScrollIntoView(), yet I don't see the green border-left because the border is zero wide. Try the URL in this bug, Flow scrolls the post but no green.
Comment 1 Danny Horn 2014-06-30 17:12:05 UTC 
Added this to backlog: https://trello.com/c/Lc84qXjm
Comment 2 Jon 2014-07-01 22:46:21 UTC 
Works for me http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA&workflow=rxp699sikbd30f10#flow-post-rxp69sxjgbh24q38

I think I fixed this as part of I0519643a1c0c398bcec124664359bc97e65effdc

FYI this bug report is not very clear at all. Please include steps to replicate in future it took me a lot of unnecessary time trying to work out what the problem was.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links