Last modified: 2014-07-16 13:58:10 UTC
(with master Wikibase) there is no "add" button for site links when javascript is enabled. http://snag.gy/XcZ09.jpg When javascript is disabled, the css for the <td> right border in the add/edit links column is a bit broken. http://snag.gy/nEFlz.jpg the site links broke with https://gerrit.wikimedia.org/r/#/c/140088/ which added a span tag and changed which element has the .wb-editsection. https://gist.github.com/filbertkm/9014f962ebcffcd03cf8/revisions The css and javascript is not adjusted accordingly. Furthermore, this is a breaking change that needs a DEPLOY note to purge the parser cache. Purging the parser cache is something we really don't want to do very often and only if absolutely needed. If possible and not too difficult, I prefer the css / javascript to be adjusted with backwards compatibility to work with either version of the html and not have to purge the parser cache for this.
Change 142523 had a related patch set uploaded by Aude: Partial revert of I2e7bd49b to fix add site links bug https://gerrit.wikimedia.org/r/142523
Change 143022 had a related patch set uploaded by Aude: Fix site links 'add' links button in javascript https://gerrit.wikimedia.org/r/143022
now broken on wikidata beta: http://wikidata.beta.wmflabs.org/wiki/Q27843
Change 143584 had a related patch set uploaded by Adrian Lang: Fix site links edit sections https://gerrit.wikimedia.org/r/143584
Change 143022 abandoned by Aude: Fix site links 'add' links button in javascript https://gerrit.wikimedia.org/r/143022
Change 142523 abandoned by Aude: Partial revert of I2e7bd49b to fix add site links bug Reason: no longer needed https://gerrit.wikimedia.org/r/142523
Change 143584 merged by jenkins-bot: Fix site links edit sections https://gerrit.wikimedia.org/r/143584
