Last modified: 2014-07-06 22:33:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69271, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67271 - special page delete revision tabindex order incorrect
special page delete revision tabindex order incorrect
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page deletion (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: 1.24.0 release
Assigned To: Alexandre Emsenhuber [IAlex]
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-29 08:34 UTC by Andyrom75
Modified: 2014-07-06 22:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andyrom75 2014-06-29 08:34:27 UTC
On https://it.wikivoyage.org, the page "Speciale:CancellaRevisione" (see as an example this page: https://it.wikivoyage.org/w/index.php?title=Speciale:CancellaRevisione&target=Speciale%3ARegistri%2Fdelete&type=logging&ids=279691) has a wrong tabindex order.

In particular.
* wpHidePrimary HAS NOT a tabindex
* wpHideComment HAS NOT a tabindex
* wpHideUser HAS NOT a tabindex
* wpRevDeleteReasonList has tabindex=1
* wpReason HAS NOT a tabindex 
* submit HAS NOT a tabindex
* search has tabindex=2

Because of this, after the selection of the delete reason, the tab click bring the focus from wpRevDeleteReasonList to search instead of wpReason.

The right tabindex order should be the following:
* wpHidePrimary: tabindex=1
* wpHideComment: tabindex=2
* wpHideUser: tabindex=3
* wpRevDeleteReasonList: tabindex=4
* wpReason: tabindex=5
* submit: tabindex=6
* search: tabindex=7

PS
I'm not sure 100% but I think that previously this was working fine.

Can someone fix it?
Comment 1 Gerrit Notification Bot 2014-07-06 06:23:51 UTC
Change 144348 had a related patch set uploaded by IAlex:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348
Comment 2 Gerrit Notification Bot 2014-07-06 10:06:28 UTC
Change 144348 had a related patch set uploaded by Bartosz Dziewoński:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348
Comment 3 Gerrit Notification Bot 2014-07-06 10:11:32 UTC
Change 144348 merged by jenkins-bot:
Remove tabindex from the drop-down in Special:RevisionDelete

https://gerrit.wikimedia.org/r/144348
Comment 4 Andyrom75 2014-07-06 12:42:06 UTC
A question just to be sure. Considering that currently the behaviour of the tabindexes hasn't changes, is correct to say that fixed doesn't mean deployed?
Comment 5 Bartosz Dziewoński 2014-07-06 19:16:57 UTC
(In reply to Andyrom75 from comment #4)
> A question just to be sure. Considering that currently the behaviour of the
> tabindexes hasn't changes, is correct to say that fixed doesn't mean
> deployed?

Yes. New versions are deployed on WMF sites according to this schedule:
[[mw:MediaWiki 1.24/Roadmap]]. This fix will be part of version 1.24wmf13.
It is possible to backport a change and deploy it immediately (or within
24 hours, at least), but that's usually reserved for severe bugs affecting
most of readers or editors.
Comment 6 Andyrom75 2014-07-06 22:33:54 UTC
Thanks for the clarification. It's not so urgent indeed; mine was just curiosity.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links