Last modified: 2014-09-07 03:45:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69276, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67276 - edit conflict raises PageNotSaved exception instead of EditConflict
edit conflict raises PageNotSaved exception instead of EditConflict
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-29 14:57 UTC by xqt
Modified: 2014-09-07 03:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description xqt 2014-06-29 14:57:18 UTC
>>> Benutzer Diskussion:Bernd Schwabe in Hannover <<<
+
+ {{ers:user:xqbot/LD-Hinweis|Harald Härke|angelegte}}

Comment: Bot: Benachrichtigung über Löschdiskussion zum Artikel [[Harald Härke]]

Traceback (most recent call last):
  File "C:\pwb\core\pwb.py", line 153, in <module>
    run_python_file(fn, argv, argvu)
  File "C:\pwb\core\pwb.py", line 67, in run_python_file
    exec(compile(source, filename, "exec"), main_mod.__dict__)
  File "C:\pwb\core\scripts\la.py", line 273, in <module>
    main()
  File "C:\pwb\core\scripts\la.py", line 265, in main
    bot.run()
  File "C:\pwb\core\scripts\la.py", line 96, in run
    self.treat(article)
  File "C:\pwb\core\scripts\la.py", line 156, in treat
    self.inform(user, page=page.title(), action=u'angelegte')
  File "C:\pwb\core\scripts\la.py", line 194, in inform
    if not self.save(text, talk, self.summary % param, minorEdit=False):
  File "C:\pwb\core\scripts\la.py", line 238, in save
    minorEdit=minorEdit, botflag=botflag)
  File "C:\pwb\core\pywikibot\page.py", line 964, in put
    **kwargs)
  File "C:\pwb\core\pywikibot\__init__.py", line 423, in wrapper
    return method(*__args, **__kw)
  File "C:\pwb\core\pywikibot\page.py", line 885, in save
    **kwargs)
  File "C:\pwb\core\pywikibot\page.py", line 911, in _save
    raise pywikibot.PageNotSaved("%s: %s" % (link, err))
pywikibot.exceptions.PageNotSaved: [[Benutzer Diskussion:Bernd Schwabe in Hannover]]: editpage: Edit conflict detected; saving aborted.
<class 'pywikibot.exceptions.PageNotSaved'>
CRITICAL: Waiting for 1 network thread(s) to finish. Press ctrl-c to abort

The Problem is that try: ... except pywikibot.EditConflict does not hints the exceptions but it should do.
Comment 1 John Mark Vandenberg 2014-06-29 15:03:19 UTC
This is the bug I was aiming to fix with
https://gerrit.wikimedia.org/r/141398
Comment 2 Gerrit Notification Bot 2014-06-29 16:28:16 UTC
Change 142901 had a related patch set uploaded by Xqt:
(bug 67276) do not pass exceptions silently

https://gerrit.wikimedia.org/r/142901
Comment 3 Gerrit Notification Bot 2014-07-05 17:01:36 UTC
Change 142901 abandoned by Xqt:
(bug 67276) do not pass exceptions silently

https://gerrit.wikimedia.org/r/142901
Comment 4 Ricordisamoa 2014-07-20 11:58:16 UTC
Change 141398 had a related patch set uploaded by John Vandenberg:
WIP: Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398
Comment 5 Gerrit Notification Bot 2014-08-19 05:10:20 UTC
Change 141398 had a related patch set uploaded by John Vandenberg:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398
Comment 6 Gerrit Notification Bot 2014-09-06 15:34:42 UTC
Change 141398 merged by XZise:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links