Last modified: 2014-10-22 01:13:47 UTC
Writing https://gerrit.wikimedia.org/r/143322 , I realized that the `ve.ce.isShortcutKey( e )` check in ve.ce.Surface (which rejects every keypress event where Ctrl or Cmd is pressed) sometimes prevent legit keypresses from being handled. To reproduce (in any browser): * Place cursor on an empty line. * Input 'ą' ([[ą]]). This is accomplished by pressing AltGr+a (right Alt+a, Alt+Ctrl+a) when using the "Polish (Programmers)" keyboard layout on Windows 7 (this is the default layout for Polish). * Type in something else. The 'ą' disappears, because it was never handled by ve.ce, only by native contenteditable element. I only tested this on Windows 7, but I believe other operating systems all use the same method. Other letters with diacritics from the [[Polish alphabet]] are input in the same way (AltGr + base key), we have nine of them. On Windows 7 you can enable this keyboard layout by typing "keyboard layout" into the Start menu, choosing "Change keyboards…" and adding the input method.
Is this now fixed, given that we've killed pawns?
(In reply to James Forrester from comment #1) > Is this now fixed, given that we've killed pawns? We haven't quite killed them yet, the chimera commit does that.
(In reply to Roan Kattouw from comment #2) > (In reply to James Forrester from comment #1) > > Is this now fixed, given that we've killed pawns? > > We haven't quite killed them yet, the chimera commit does that. But we should make sure that that commit also kills this logic; which right now I'm not sure that it does.
I can still reproduce on betalabs.
Hmph, we can't kill this code yet. It's not just to prevent pawning, it's also to prevent the selection from being deleted when you press a shortcut key. We'll need David's next project (prepare-observe-fixup) to be done before we can get rid of this, I think.
