Last modified: 2014-10-12 14:32:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69375, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67375 - Hardcoded colons in translatable strings - Non-breaking space needed in French for Quiz
Hardcoded colons in translatable strings - Non-breaking space needed in Frenc...
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Quiz (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-01 17:42 UTC by JackPotte
Modified: 2014-10-12 14:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description JackPotte 2014-07-01 17:42:17 UTC
Hello,
The French typographic rules impose to add a non-breaking space before each colon.

However the quiz extension doesn't provide it in its introduction about the points, and I can't find any Mediawiki or TranslateWiki page for it.

As discussed here:
https://fr.wikiversity.org/wiki/Wikiversit%C3%A9:La_salle_caf%C3%A9/27_2014#Balise_quiz
Comment 1 Andre Klapper 2014-07-02 08:32:29 UTC
> However the quiz extension doesn't provide it in its introduction about the points

Where and how to see that (URL)?  (Code is at https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FQuiz.git if you feel like taking a look.)
Comment 2 JackPotte 2014-07-02 09:05:15 UTC
The discussion on my URL displays it in French, but I must be able to check /i18n/fr.json and submit it this evening...
Comment 3 Andre Klapper 2014-07-02 12:38:30 UTC
The problem is the TODO here: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FQuiz.git/b23418d4903d448f7a478403925230400249c668/Quiz.class.php#L140

A really ugly hack might be to change the French translations in Quiz.i18n.php to end with an nbsp but I have no idea if our translation format supports entering and processing that. Somehow.
Comment 4 JackPotte 2014-07-02 19:46:46 UTC
I had removed the three colons in this file (rather not than without space, to initiate any Translatewiki colons addition after), but I can't push by using my Gerrit account:

$ git push --set-upstream quiz master
Username for 'https://git.wikimedia.org': JackPotte
Password for 'https://JackPotte@git.wikimedia.org':
fatal: Authentication failed for 'https://git.wikimedia.org/git/mediawiki/extensions/Quiz.git/'

$ git push --set-upstream quiz master
Username for 'https://gerrit.wikimedia.org': JackPotte
Password for 'https://JackPotte@gerrit.wikimedia.org':
fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Quiz.git/'
Comment 5 Andre Klapper 2014-07-02 21:43:38 UTC
You probably need to use Gerrit for this to get a review first - see http://www.mediawiki.org/wiki/Gerrit/Tutorial or http://tools.wmflabs.org/gerrit-patch-uploader/ as a shortcut.
Comment 6 JackPotte 2014-10-05 13:23:20 UTC
https://gerrit.wikimedia.org/r/#/settings/group-memberships indicates that I'm 
 Anonymous Users	
 Registered Users
 mediawiki-training
So it seems I don't have the right to submit any modification for now.
Comment 7 Andre Klapper 2014-10-05 20:09:51 UTC
(In reply to JackPotte from comment #6)
> So it seems I don't have the right to submit any modification for now.

Did you follow the steps in https://www.mediawiki.org/wiki/Developer_access ?
Comment 8 JackPotte 2014-10-05 20:27:13 UTC
I've got a Wikitech shell account since the beginning, but my groups are:
Registered users, Users, shell
Comment 9 Andre Klapper 2014-10-07 18:11:48 UTC
JackPotte: If you think that you don't have sufficient rights, please do paste the commands and error messages here when you follow https://www.mediawiki.org/wiki/Gerrit/Tutorial
Comment 10 JackPotte 2014-10-11 21:19:38 UTC
I've regenerated an SSH key, re-added it into Git Bash, Gerrit and Wikitech, and recloned Quiz. But finally the same error occurred during the push:
/Git/quiz (master)
$ git push https://gerrit.wikimedia.org/r/mediawiki/extensions/Quiz HEAD:refs/f
or/master
Username for 'https://gerrit.wikimedia.org': JackPotte
Password for 'https://JackPotte@gerrit.wikimedia.org':
fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/mediawiki/exten
sions/Quiz/'

/Git/quiz (master)


The password I've entered several times works on https://gerrit.wikimedia.org/


It may be simpler if someone else could proceed, Quiz.class.php took me less than one minute to be modified.
Comment 11 Bartosz Dziewoński 2014-10-11 21:24:52 UTC
You must set a separate password to push via HTTPS: https://gerrit.wikimedia.org/r/#/settings/http-password .

But I'm not aware of anyone who has successfully uses that, people usually push via SSH after adding public key at https://gerrit.wikimedia.org/r/#/settings/ssh-keys .
Comment 12 JackPotte 2014-10-11 22:03:39 UTC
Thank you, the authentication has worked in HTTPS, but now I've got "prohibited by Gerrit", by pushing in HTTPS or SSH, with the branch "master" or another:

/Git/quiz (master)
$ git push
Username for 'https://gerrit.wikimedia.org': jackpotte
Password for 'https://jackpotte@gerrit.wikimedia.org':
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 352 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Branch refs/heads/master:
remote: You are not allowed to perform this operation.
remote: To push into this reference you need 'Push' rights.
remote: User: jackpotte
remote: Please read the documentation and contact an administrator
remote: if you feel the configuration is incorrect
remote: Processing changes: refs: 1, done
To https://gerrit.wikimedia.org/r/mediawiki/extensions/Quiz
 ! [remote rejected] master -> master (prohibited by Gerrit)
error: failed to push some refs to 'https://gerrit.wikimedia.org/r/mediawiki/ext
ensions/Quiz'


/Git/quiz (master)
$ git push origin master
Enter passphrase for key '/c/Users/jackpotte/.ssh/id_rsa':
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 352 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Branch refs/heads/master:
remote: You are not allowed to perform this operation.
remote: To push into this reference you need 'Push' rights.
remote: User: jackpotte
remote: Please read the documentation and contact an administrator
remote: if you feel the configuration is incorrect
remote: Processing changes: refs: 1, done
To ssh://jackpotte@gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz
 ! [remote rejected] master -> master (prohibited by Gerrit)
error: failed to push some refs to 'ssh://jackpotte@gerrit.wikimedia.org:29418/m
ediawiki/extensions/Quiz'
Comment 13 Bartosz Dziewoński 2014-10-11 22:41:23 UTC
You still need to push to 'refs/for/master', like in the command you had in comment 10. You can't directly push to 'master' unless you have "Push" rights, like the error message explains (which no one has for most of our repositories, as far as I know).
Comment 14 JackPotte 2014-10-12 13:27:17 UTC
Now it seems to refuse my Change-Id, I tried to follow the hint below without success:

$ git push ssh://jackpotte@gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz
 HEAD:refs/for/master
Enter passphrase for key '/c/Users/hbossot/.ssh/id_rsa':
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 352 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done
remote: ERROR: missing Change-Id in commit message footer
remote: Suggestion for commit message:
remote: https://bugzilla.wikimedia.org/show_bug.cgi?id=67375
remote:
remote: Change-Id: I6d592bddb47ada1e221e3d6921a1b62484ee3e04
remote:
remote: Hint: To automatically insert Change-Id, install the hook:
remote:   gitdir=$(git rev-parse --git-dir); scp -p -P 29418 jackpotte@gerrit.wi
kimedia.org:hooks/commit-msg ${gitdir}/hooks/
remote:
remote:
To ssh://jackpotte@gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz
 ! [remote rejected] HEAD -> refs/for/master (missing Change-Id in commit messag
e footer)
error: failed to push some refs to 'ssh://jackpotte@gerrit.wikimedia.org:29418/m
ediawiki/extensions/Quiz'


I've posted the summary of my process:
https://www.mediawiki.org/w/index.php?title=User%3AJackPotte&diff=1222023&oldid=1014645
Comment 15 JackPotte 2014-10-12 13:33:42 UTC
Finally it seems to work by manually inserting the change ID above:


$ git push ssh://jackpotte@gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz
 HEAD:refs/for/master
Enter passphrase for key '/c/Users/hbossot/.ssh/id_rsa':
Counting objects: 5, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 398 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: new: 1, refs: 1, done
remote:
remote: New Changes:
remote:   https://gerrit.wikimedia.org/r/166284
remote:
To ssh://jackpotte@gerrit.wikimedia.org:29418/mediawiki/extensions/Quiz
 * [new branch]      HEAD -> refs/for/master
Comment 16 Gerrit Notification Bot 2014-10-12 14:32:17 UTC
Change 166284 had a related patch set uploaded by Bartosz Dziewoński:
Do not hardcode colons outside of translatable strings

https://gerrit.wikimedia.org/r/166284

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links