Last modified: 2014-07-01 20:43:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69387, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67387 - Upload on commons disabled
Upload on commons disabled
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikimediaMessages (Other open bugs)
master
All All
: Immediate critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-01 19:41 UTC by Steinsplitter
Modified: 2014-07-01 20:43 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Tomasz W. Kozlowski 2014-07-01 19:45:30 UTC
Raising importance since that's a very critical bug that's blocking hundreds (thousands?) of uploads on Commons right now.
Comment 3 Robin Pepermans (SPQRobin) 2014-07-01 19:52:39 UTC
(In reply to Krinkle from comment #2)
> Likely caused by
> https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
> c6e84ba3

That was supposed to fix it.
Comment 4 Krinkle 2014-07-01 19:53:04 UTC
In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but caused this as a regression. 

Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be backported to 1.24wmf11.
Comment 5 Sam Reed (reedy) 2014-07-01 19:53:58 UTC
(In reply to Krinkle from comment #2)
> Likely caused by
> https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/commit/
> c6e84ba3

Caused by? It was the commit to make it content language (not user language), which was backported and deployed to the cluster?

https://gerrit.wikimedia.org/r/#/q/Ife55252fa3a8c575d13c41420814f42b914aa90d,n,z
Comment 6 Sam Reed (reedy) 2014-07-01 19:55:02 UTC
(In reply to Krinkle from comment #4)
> In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
> caused this as a regression. 
> 
> Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
> backported to 1.24wmf11.

https://gerrit.wikimedia.org/r/142384

https://gerrit.wikimedia.org/r/142387
Comment 7 Krinkle 2014-07-01 19:55:31 UTC
(In reply to Krinkle from comment #4)
> In fact, caused by I364f48f387d5987 (fulfilling request from bug 66960), but
> caused this as a regression. 
> 
> Change c6e84ba3d35e0d237e48 fixes it and has already been merged. Should be
> backported to 1.24wmf11.

Was already backported as 650ce038a86ee8408861 5 days ago. Guess that didn't fix it.
Comment 8 Sam Reed (reedy) 2014-07-01 19:56:56 UTC
reedy@mw1017:/usr/local/apache/common/php-1.24wmf11/extensions/WikimediaMessages$ grep "UploadForm:initial" WikimediaMessages.php -A 10
$wgHooks['UploadForm:initial'][] = function() {
        if ( wfMessage( 'licenses' )->inContentLanguage()->isDisabled() ) {
                throw new ErrorPageError( 'uploaddisabled', 'wikimedia-upload-nolicenses' );
        }
};
Comment 9 Robin Pepermans (SPQRobin) 2014-07-01 19:58:46 UTC
It works on all other wikis, so there appears to be somehow something Commons-specific...
Comment 10 Robin Pepermans (SPQRobin) 2014-07-01 20:03:16 UTC
I see the problem, Commons is one of the few wikis with 'licenses' in $wgForceUIMsgAsContentMsg.
Comment 11 Gerrit Notification Bot 2014-07-01 20:11:31 UTC
Change 143396 had a related patch set uploaded by SPQRobin:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396
Comment 12 Gerrit Notification Bot 2014-07-01 20:25:29 UTC
Change 143396 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143396
Comment 13 Gerrit Notification Bot 2014-07-01 20:25:45 UTC
Change 143403 had a related patch set uploaded by Reedy:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403
Comment 14 Gerrit Notification Bot 2014-07-01 20:27:26 UTC
Change 143403 merged by jenkins-bot:
(bug 67387) Fix MediaWiki:Licenses requirement

https://gerrit.wikimedia.org/r/143403
Comment 15 Steinsplitter 2014-07-01 20:39:26 UTC
Works now. Thanks for fixing the bug so fast. :-)
Comment 16 Tomasz W. Kozlowski 2014-07-01 20:43:03 UTC
Verified to work.  Thanks again, guys.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links