Last modified: 2014-07-02 23:54:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69391, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67391 - Flow: close-reopen topic ignores requested moderationState
Flow: close-reopen topic ignores requested moderationState
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ee-flow.wmflabs.org/w/index.ph...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-01 21:37 UTC by spage
Modified: 2014-07-02 23:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-07-01 21:37:27 UTC
While testing action=close-open-topic I returned to an old URL
workflow=<someTopic_UUID>&action=close-open-topic&flow_moderationState=close when someTopic was already closed.

Even though I'm directing it to close, the form's button is [Reopen topic] and the form's action is flow_moderationState=restore.  Likewise if you do the inverse: if you try to reopen a topic that's already open, Flow just closes it. flow_moderationState is ignored.

I think at the API level Flow detects and warn "You can not close a moderated post" (flow-error-close-moderated-post).  At the URL level it should work similarly: if you tell Flow to close a closed topic or restore one that's open, Flow shouldn't do the opposite of what you request, it should warn. I think that means adding a message for flow-error-restore-open-post.
Comment 1 Danny Horn 2014-07-02 23:54:19 UTC
Added to backlog: https://trello.com/c/xMdQoW7q

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links