Last modified: 2014-09-05 05:25:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69401, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67401 - Flow front-end: escape topic title's HTML in h1 firstHeader when viewing isolated topic
Flow front-end: escape topic title's HTML in h1 firstHeader when viewing isol...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ee-flow.wmflabs.org/wiki/Talk:...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-02 01:01 UTC by spage
Modified: 2014-09-05 05:25 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-07-02 01:01:40 UTC 
Topic title is text, so HTML entities in it simply appear.

But when you view a standalone topic (from a permalink, or when you open a topic action action in a new tab, or presumably when you choose a topic action with no-JavaScript), Flow puts the un-escaped topic title in the <h1 class="firstHeading"> and in the <title> tag.

Compare the URL above with https://test.wikipedia.org/wiki/Talk:Sandbox?workflow=rxpkw658tqvrvnsd
Comment 1 Gerrit Notification Bot 2014-07-02 02:29:18 UTC 
Change 143552 had a related patch set uploaded by Spage:
Escape topic title HTML shown in h1 firstHeading

https://gerrit.wikimedia.org/r/143552
Comment 2 Danny Horn 2014-07-02 23:58:40 UTC 
Added to backlog: https://trello.com/c/0k2bX2qe
Comment 3 Gerrit Notification Bot 2014-07-08 16:38:03 UTC 
Change 143552 merged by jenkins-bot:
Escape topic title HTML shown in h1 firstHeading

https://gerrit.wikimedia.org/r/143552
Comment 4 spage 2014-07-09 22:25:46 UTC 
Fixed in 1.24wmf13
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links