Last modified: 2014-08-05 20:12:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69418, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67418 - CirrusSearch: Regex knock on issues
CirrusSearch: Regex knock on issues
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nik Everett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-02 15:29 UTC by Nik Everett
Modified: 2014-08-05 20:12 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2014-07-02 15:29:09 UTC
Regex queries will need more time to run than the standard 10 seconds.  We should give them 30 or something.

Also, we should improve the error message when a query times out.

Finally, we should *make sure* that the regex filter comes last in the chain of stuff that Elasticsearch does because we know it'll be the slowest thing.  That way we're super duper sure that stuff like <<insource:foo insource:/foo/>> is actually faster then plain <<insource:/foo/>>.
Comment 1 Gerrit Notification Bot 2014-07-08 19:58:34 UTC
Change 144748 had a related patch set uploaded by Manybubbles:
Raise regex timeout to 120 seconds

https://gerrit.wikimedia.org/r/144748
Comment 2 Nik Everett 2014-07-08 19:59:12 UTC
Still need another patch - this one to make sure the regex comes last.
Comment 3 Gerrit Notification Bot 2014-07-09 01:28:36 UTC
Change 144748 merged by jenkins-bot:
Raise regex timeout to 120 seconds

https://gerrit.wikimedia.org/r/144748
Comment 4 Gerrit Notification Bot 2014-07-09 20:32:21 UTC
Change 145079 had a related patch set uploaded by Manybubbles:
Script filters are executed last

https://gerrit.wikimedia.org/r/145079
Comment 5 Gerrit Notification Bot 2014-07-09 20:42:07 UTC
Change 145079 merged by jenkins-bot:
Script filters are executed last

https://gerrit.wikimedia.org/r/145079
Comment 6 Tomasz W. Kozlowski 2014-08-05 20:12:50 UTC
Both patches have been merged, assuming bug is fixed.

Please re-open if that's not the case.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links