Last modified: 2014-10-07 21:33:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69565, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67565 - Loading es5-shim module causes error in IE <= 8
Loading es5-shim module causes error in IE <= 8
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: ---
Assigned To: Kevin Israel (PleaseStand)
: upstream
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-06 13:31 UTC by Kevin Israel (PleaseStand)
Modified: 2014-10-07 21:33 UTC (History)
5 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
aklapper: Backport_WMF+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kevin Israel (PleaseStand) 2014-07-06 13:31:56 UTC 
Apparently I2556b39d did not really add v3.4.0 of es5-shim but rather a newer version affected by <https://github.com/es-shims/es5-shim/issues/253>. This makes es5-shim unusable for its primary purpose in MediaWiki: providing compatibility with old versions of IE.

I ran into this bug, which causes errors even for (non-core) site JS, while working on a user script on English Wikipedia.
Comment 1 Gerrit Notification Bot 2014-07-06 13:35:33 UTC 
Change 144359 had a related patch set uploaded by PleaseStand:
Update es5-shim to bb74ba2 (2014-06-25)

https://gerrit.wikimedia.org/r/144359
Comment 2 Kevin Israel (PleaseStand) 2014-07-07 12:42:14 UTC 
(In reply to Kevin Israel (PleaseStand) from comment #0)
> I ran into this bug, which causes errors even for (non-core) site JS, while
> working on a user script on English Wikipedia.

I think this is because of MultimediaViewer (see also bug 67590).

My motivation for using es5-shim and reporting this bug, however, is that I have a user script on English Wikipedia that otherwise would need its own date parsing code <https://en.wikipedia.org/w/index.php?title=User:PleaseStand/userinfo.js&diff=615803540&oldid=603055971>.
Comment 3 Gerrit Notification Bot 2014-07-10 17:45:05 UTC 
Change 144359 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/144359
Comment 4 Gerrit Notification Bot 2014-07-10 18:42:16 UTC 
Change 145400 had a related patch set uploaded by Jforrester:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145400
Comment 5 Gerrit Notification Bot 2014-07-10 18:42:39 UTC 
Change 145401 had a related patch set uploaded by Jforrester:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145401
Comment 6 Gerrit Notification Bot 2014-07-10 23:12:38 UTC 
Change 145400 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145400
Comment 7 Gerrit Notification Bot 2014-07-10 23:17:15 UTC 
Change 145401 merged by jenkins-bot:
Update es5-shim to latest master (40181d720e07)

https://gerrit.wikimedia.org/r/145401
Comment 8 Andre Klapper 2014-10-07 21:33:51 UTC 
[Backport was merged into 1.24wmf12 and 1.24wmf13 upon a time, hence setting Backport_WMF flag to +]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links