Last modified: 2014-07-10 16:27:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69587, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67587 - GraphViz extension: updating DOT code does not lead to new diagram
GraphViz extension: updating DOT code does not lead to new diagram
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Other (Other open bugs)
REL1_19-branch
All All
: Unprioritized normal (vote)
: ---
Assigned To: Keith Welter
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-07 11:06 UTC by Martin Schneider
Modified: 2014-07-10 16:27 UTC (History)
2 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Martin Schneider 2014-07-07 11:06:40 UTC
Intention:
I use the GraphViz extension v1.3.0 on top of MediaWiki v1.19.17 to draw diagrams from DOT code. The diagram is created in the correct way. But when updating the DOT code and saving the MediaWiki page again the diagram is not updated (the old diagram is shown.)

Steps to Reproduce:
1. Versions: MediaWiki 1.19.17, GraphViz extension 1.3.0
2. Create a page with a simple GraphViz example on it:
== simple graphViz test ==

=== Example 1 from http://www.mediawiki.org/wiki/Extension:GraphViz ===
<graphviz border='frame' format='png'>
digraph example1 {Hello->"World!"}
</graphviz>

3. Save the page.
4. The page is shown with the diagram in the correct way. 
5. Edit the DOT code on the page, e.g. add another node and edge:
== simple graphViz test ==

=== Example 1 from http://www.mediawiki.org/wiki/Extension:GraphViz ===
<graphviz border='frame' format='png'>
digraph example1 {Hello->"World!";
Hello->Goodbye;}
</graphviz>

6. Save the changes
7. The old diagram is shown without the additional node "Goodbye" and the edge from "Hello" to "Goodbye"

Actual Results:  
The old diagram is shown.

Expected Results:  
The updated diagram should be shown.

Reproducible: Always
Comment 1 Andre Klapper 2014-07-07 12:45:16 UTC
Thanks for taking the time to report this!

CC'ing GraphViz' maintainer (plus wondering if there is a dedicated bugtracker for GraphViz that I'm not aware of - if there is, then I fail to find out on https://www.mediawiki.org/wiki/Extension:GraphViz ).
Comment 2 Keith Welter 2014-07-07 15:27:31 UTC
I've confirmed this bug and have a fix ready.  Please assign this bug to me.
Comment 3 Keith Welter 2014-07-07 15:55:02 UTC
The problem is that the GraphViz extension 1.0+ uses two hooks and one function that were introduced in MW 1.21 (PageContentSave, PageContentSaveComplete and WikiPage::doEdit respectively). 

The fix is for the extension to use the older hooks and function for MW versions <1.21 (ArticleSave, ArticleSaveComplete and WikiPage::doEditContent respectively).
Comment 4 Gerrit Notification Bot 2014-07-07 16:14:25 UTC
Change 144467 had a related patch set uploaded by Welterkj:
Backward compatibility fix for MW version <1.21.

https://gerrit.wikimedia.org/r/144467
Comment 5 Gerrit Notification Bot 2014-07-10 16:04:02 UTC
Change 144467 merged by jenkins-bot:
Backward compatibility fix for MW version <1.21.

https://gerrit.wikimedia.org/r/144467
Comment 6 Keith Welter 2014-07-10 16:27:33 UTC
The fix is now available from Git and Packagist (via Composer).  See the installation instructions and confirm you have version 1.3.1 when verifying this fix.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links