Last modified: 2014-08-28 16:59:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69590, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67590 - Ship Object.create polyfill for OOjs for compatibility with browser having ES3 engines
Ship Object.create polyfill for OOjs for compatibility with browser having ES...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: High minor (vote)
: 1.24.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-07 12:35 UTC by Kevin Israel (PleaseStand)
Modified: 2014-08-28 16:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kevin Israel (PleaseStand) 2014-07-07 12:35:51 UTC
After installing the MultimediaViewer extension, setting $wgIncludejQueryMigrate = true (bug 66098), and applying the fix for bug 67565, I get the following error in IE 8:

Object doesn't support this property or method
oojs.js, line 89 character 2

targetFn.prototype = Object.create( originFn.prototype, {
	// Restore constructor property of targetFn
	constructor: {
		value: targetConstructor,
		enumerable: false,
		writable: true,
		configurable: true
	}
} );
Comment 1 James Forrester 2014-08-21 19:53:49 UTC
This is a bug with MediaWiki core's use of an ES5-only library with a good enough shim, not with the library
Comment 2 Gerrit Notification Bot 2014-08-25 12:28:13 UTC
Change 156046 had a related patch set uploaded by Krinkle:
es5-shim: Add polyfill for Object.create

https://gerrit.wikimedia.org/r/156046
Comment 3 Gerrit Notification Bot 2014-08-28 16:59:00 UTC
Change 156046 merged by jenkins-bot:
es5-shim: Add polyfill for Object.create

https://gerrit.wikimedia.org/r/156046

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links