Last modified: 2014-11-07 11:58:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69604, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67604 - time formatting issues with some precisions
time formatting issues with some precisions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
: 71289 71956 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-07 16:56 UTC by Lydia Pintscher
Modified: 2014-11-07 11:58 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lydia Pintscher 2014-07-07 16:56:50 UTC
https://test.wikidata.org/wiki/Q22

When entering "1 January 23" as a date and setting precision to century or less formatting seems to be broken. "+00000000023-01-01T00:00:00Z" is shown instead.
Comment 1 Thiemo Mättig 2014-07-07 18:25:24 UTC
That's actually a feature I recently introduced.

Formatting the year 123 as a century results in "1. century". That's a bit odd (you loose a lot of information) but kind of ok.

But what do you expect from the year 23? "0. century"? "0 million years ago"? I think this needs a fallback. My current fallback is to show the internal format. Other possible fallbacks:

* Show "0 million years ago" and so on.
* Show "0" with nothing attached.
* Show an error message.
* Show the year as it is (basically fall back to "year" precision").

Please decide. I suggest the last one.
Comment 2 Bartosz Dziewoński 2014-07-07 18:29:49 UTC
(In reply to Thiemo Mättig from comment #1)
> Formatting the year 123 as a century results in "1. century". That's a bit
> odd (you loose a lot of information) but kind of ok.

Surely that's the second century, not first, unless you're talking about time deltas and not dates? (I don't know the context, seen this scroll by on IRC.)
Comment 3 Thiemo Mättig 2014-07-07 21:12:29 UTC
(In reply to Bartosz Dziewoński from comment #2)
> that's the second century

Correct. We just realized that's an other bug in the current implementation. The "2. century" can also be expressed as "1 century A.D.". And it depends on the language what you need for what precision. We usually say "1 million years" and not "2. age", but this may be different in other languages. So all these messages need two placeholders or what?

Not mentioning the 1990s. Is "199 decades A.D." the same as "1990s" and is that the same as "199. decade A.D."?

Oh wow, language support is fun.
Comment 4 Thiemo Mättig 2014-10-14 18:03:42 UTC
*** Bug 71289 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2014-10-14 18:51:15 UTC
Change 166622 had a related patch set uploaded by Thiemo Mättig (WMDE):
Display full year if precision is to high

https://gerrit.wikimedia.org/r/166622
Comment 6 Thiemo Mättig 2014-10-14 18:53:16 UTC
*** Bug 71956 has been marked as a duplicate of this bug. ***
Comment 7 Gerrit Notification Bot 2014-10-17 10:02:59 UTC
Change 166622 merged by jenkins-bot:
Display full year if precision is to high

https://gerrit.wikimedia.org/r/166622
Comment 8 Henning 2014-10-28 16:17:18 UTC
Seems like it has been forgotten to set the ticket to "fixed" (at the end, it is just high/major anyway... ;) ). Since the change has been merged, I just verified its behaviour--no ISO string returned anymore.
Comment 9 Thiemo Mättig 2014-11-07 11:58:15 UTC
*** Bug 71289 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links