Last modified: 2014-09-29 20:11:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69616, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67616 - QA tests in mediawiki-core should have no logic or mention of Wikimedia Foundation wikis
QA tests in mediawiki-core should have no logic or mention of Wikimedia Found...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.24rc
All All
: High normal (vote)
: 1.24.0 release
Assigned To: Chris McMahon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-07 18:46 UTC by Krinkle
Modified: 2014-09-29 20:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
legoktm.wikipedia: Backport_to_Stable+


Attachments

Description Krinkle 2014-07-07 18:46:20 UTC
See also https://gerrit.wikimedia.org/r/#/c/143199/

Please refactor these soon so that they take wikis (and ideally browsers as well) via run-time configuration instead of hardcoded in the repository. These should be tests for the feature in general, which (depending on how they are run) can be used as up-time checker or regression indicator for a specific wiki (e.g. wmf production or beta labs). But the test itself should not have that logic in it. that should be provided from the Jenkins job running it.
Comment 1 Krinkle 2014-07-07 18:47:42 UTC
Ideally this code would not make it into a release or stable branch to avoid cluttering third-parties adopting this pattern. Targeting against 1.24 as reminder.
Comment 2 Chris McMahon 2014-08-01 15:40:05 UTC
Zeljko and I discussed this today, and we should be able to remove specific environment tags from the feature files when we implement pull-by-branch.  This is a high priority for the Release Engineering team, and we have made some progress toward this in the builds already, with Antoine's mw-api-siteinfo.py script added to the Jenkins builds.
Comment 3 Kunal Mehta (Legoktm) 2014-09-19 22:18:06 UTC
Has any progress been made on this?
Comment 4 Željko Filipin 2014-09-25 16:34:26 UTC
Chris and I have paired on it today, but ran out of time. If nothing goes wrong, we should be able to clean up Core tomorrow.
Comment 5 Gerrit Notification Bot 2014-09-26 15:43:43 UTC
Change 163182 had a related patch set uploaded by Zfilipin:
Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163182
Comment 6 Gerrit Notification Bot 2014-09-26 15:51:20 UTC
Change 162910 had a related patch set uploaded by Zfilipin:
Core browser tests no longer have site specific Cucumber tags

https://gerrit.wikimedia.org/r/162910
Comment 7 Gerrit Notification Bot 2014-09-26 19:46:17 UTC
Change 163238 had a related patch set uploaded by Legoktm:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163238
Comment 8 Gerrit Notification Bot 2014-09-26 19:52:45 UTC
Change 163182 merged by jenkins-bot:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163182
Comment 9 Gerrit Notification Bot 2014-09-26 19:53:36 UTC
Change 163238 merged by jenkins-bot:
QA: Do not mention Wikimedia Foundation wikis in browser tests

https://gerrit.wikimedia.org/r/163238
Comment 10 Kunal Mehta (Legoktm) 2014-09-26 19:54:17 UTC
Merged and backported!
Comment 11 Gerrit Notification Bot 2014-09-29 20:11:54 UTC
Change 162910 merged by jenkins-bot:
Core browser tests no longer have site specific Cucumber tags

https://gerrit.wikimedia.org/r/162910

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links