Last modified: 2014-10-27 19:07:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69654, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67654 - wikibase.domready hook not firing properly?
wikibase.domready hook not firing properly?
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=frontend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-08 03:22 UTC by Kunal Mehta (Legoktm)
Modified: 2014-10-27 19:07 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2014-07-08 03:22:37 UTC
I'm not sure whether what I think is the bug is actually the bug.

But in any case, this is related to https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js.

On first page view it works fine, but if I use my browser's refresh button, the gadget doesn't load.

I added some debug statements to the gadget, and it seems like the wikibase.domready hook isn't firing after a refresh.

Firefox 30.0 on OSX 10.9
Comment 1 User:JesseW 2014-07-08 03:29:28 UTC
Confirmed on Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20140319 Firefox/24.0 Iceweasel/24.4.0 (Debian 3.2.54-2 x86_64).
Comment 2 Henning 2014-10-27 13:28:02 UTC
The wikibase.domready hook was not supposed to be permanent and has been removed in https://gerrit.wikimedia.org/r/#/c/157794/.

You already implemented an alternative in the gadget. I would recommend attaching to the more reliable "create" event of the entityview widget as we have been trying to decouple the concept of the entityview from the concept of a page.
As entityview is a jQuery widget, a "create" event, prefixed with the widget's event prefix ("entityview") will be triggered via the jQuery widget base constructor right after the widget's _create() function has been issued.

If there are no objections, I would recommend closing this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links