Last modified: 2014-07-12 02:45:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69670, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 67670 - Breaking change in AbuseFilter's "like" operator
Breaking change in AbuseFilter's "like" operator
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Unprioritized normal with 1 vote (vote)
: ---
Assigned To: Ori Livneh
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-08 13:35 UTC by Yusuke Matsubara
Modified: 2014-07-12 02:45 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yusuke Matsubara 2014-07-08 13:35:44 UTC 
The "like" operator in AbuseFilter started behaving differently, after Bug 66930 was resolved in https://gerrit.wikimedia.org/r/#/c/141483/ .

Currently:
"a-b" like "a-b"
 => false

Previously:
"a-b" like "a-b"
 => 1

I believe this was an unexpected side effect. At least the change was not documented anywhere to prevent breakage of existing filters.
Comment 1 Yusuke Matsubara 2014-07-08 13:40:34 UTC 
66935(In reply to Yusuke Matsubara from comment #0)
> The "like" operator in AbuseFilter started behaving differently, after Bug
> 66930 was resolved in https://gerrit.wikimedia.org/r/#/c/141483/ .

Bug 66935, it seems.
Comment 2 Andre Klapper 2014-07-09 12:29:09 UTC 
Probably Ori and Aaron to comment here, as that patch seems to have created this problem?
Comment 3 Gerrit Notification Bot 2014-07-11 21:46:32 UTC 
Change 145697 had a related patch set uploaded by Ori.livneh:
Fix double escaping in AFPData::keywordLike()

https://gerrit.wikimedia.org/r/145697
Comment 4 Yusuke Matsubara 2014-07-11 21:51:44 UTC 
Sorry for not including this first, but "+" seems to need the same fix.

"a+b" like "a+b" => false
Comment 5 Gerrit Notification Bot 2014-07-12 02:43:24 UTC 
Change 145697 merged by jenkins-bot:
Fix double escaping in AFPData::keywordLike()

https://gerrit.wikimedia.org/r/145697
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links