Last modified: 2014-07-18 16:08:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69685, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67685 - hide-if boolean combiners no longer work
hide-if boolean combiners no longer work
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
HTMLForm (Other open bugs)
1.24rc
All All
: Normal normal (vote)
: 1.24.0 release
Assigned To: Brad Jorsch
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-08 19:38 UTC by Brad Jorsch
Modified: 2014-07-18 16:08 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2014-07-08 19:38:19 UTC
When a field has a data-hide-if such as '["OR",["===","foo","bar"],["===","foo","baz"]]', the field is not properly shown or hidden when element "foo" is updated.

git bisect turns up Gerrit change #133254 as the culprit, and reverting the change that patch made to mediawiki.htmlform.js lines 50–69 fixes it. Apparently jQuery does not do the "right" thing when $() is passed an array of jQuery objects.

Timo, do you have a better solution than reverting those lines?
Comment 1 Gerrit Notification Bot 2014-07-10 16:05:21 UTC
Change 145350 had a related patch set uploaded by Anomie:
Partially revert Icfe63a41

https://gerrit.wikimedia.org/r/145350
Comment 2 Gerrit Notification Bot 2014-07-18 16:08:53 UTC
Change 145350 merged by jenkins-bot:
mediawiki.htmlform: Fix broken $() call

https://gerrit.wikimedia.org/r/145350

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links