Last modified: 2014-07-09 19:58:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69728, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67728 - Hovercards makes needless API requests with empty titles params
Hovercards makes needless API requests with empty titles params
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-09 08:43 UTC by spage
Modified: 2014-07-09 19:58 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-07-09 08:43:17 UTC
Visit https://www.mediawiki.org/wiki/Talk:Sandbox, open your browser's development tools > Net panel, then mouse over the links in the informational header.

Notice that popups makes API requests to query extracts|pageimages|revisions|info for these hyperlinks. But the titles parameter is empty, so obviously the API returns nothing.

resources/ext.popups.renderer.article.js should return early if link.data( 'title' ) is empty.  And if there's no data('title') then article.init() shouldn't be called in the first place.  It seems mw.popups.selectPopupElements() is trying to filter out blank titles.
Comment 1 Derk-Jan Hartman 2014-07-09 11:31:36 UTC
This would already significantly reduce that: https://gerrit.wikimedia.org/r/#/c/134268/


But popups extension seems to have a lack of contributors, this one is in a state where both I and Prtksxna have contributed and thus don't want to self merge and that sort of leaves it dead in the water.
Comment 2 Gerrit Notification Bot 2014-07-09 11:32:04 UTC
Change 134268 had a related patch set uploaded by TheDJ:
Handle links with empty or no title attributes

https://gerrit.wikimedia.org/r/134268
Comment 3 Gerrit Notification Bot 2014-07-09 11:51:30 UTC
Change 134268 merged by jenkins-bot:
Handle links with empty or no title attributes

https://gerrit.wikimedia.org/r/134268
Comment 4 spage 2014-07-09 19:58:42 UTC
Nice job, it's fixed!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links