Last modified: 2014-09-04 00:38:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69778, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67778 - Add UserMerge support to Translate
Add UserMerge support to Translate
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks: global-user-merge 67758
  Show dependency treegraph
 
Reported: 2014-07-10 00:02 UTC by Sam Reed (reedy)
Modified: 2014-09-04 00:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-07-10 00:02:36 UTC
Translate needs a UserMergeAccountFields subscriber to support UserMerge.
Comment 1 Niklas Laxström 2014-07-11 09:14:57 UTC
Please explain what this bug is about.
Comment 2 Kunal Mehta (Legoktm) 2014-07-11 09:44:29 UTC
Any table that stores a user's id or username needs a handler for the UserMergeAccountFields hook in the UserMerge extension. It'll be necessary for bug 47918.

If Translate already supports Renameuser, adding support for UserMerge is simple, see I64f178ca186fa72d4163cf28191c45e9bac97d17 for an example in CodeReview.
Comment 3 Niklas Laxström 2014-07-11 10:36:16 UTC
*shakes head* Can someone please first make the extensions use the same hook or at least the same format for the same data.
Comment 4 Kunal Mehta (Legoktm) 2014-07-11 11:03:21 UTC
(In reply to Niklas Laxström from comment #3)
> *shakes head* Can someone please first make the extensions use the same hook
> or at least the same format for the same data.

No, because they do different things. Renameuser only needs to change things if you're storing the user's name. UserMerge needs to update rows if user id is stored as well.

Depending on how you're storing the data, you might need to use a different hook point as well (ex: AccountAudit in I4deffe2c9969f9a1a4a679b1ee2a9f902a59fcab).
Comment 5 Niklas Laxström 2014-07-11 13:11:46 UTC
(In reply to Kunal Mehta (Legoktm) from comment #4)
> (In reply to Niklas Laxström from comment #3)
> > *shakes head* Can someone please first make the extensions use the same hook
> > or at least the same format for the same data.
> 
> No, because they do different things. Renameuser only needs to change things
> if you're storing the user's name. UserMerge needs to update rows if user id
> is stored as well.

But in your example you are providing the same data just in slightly different formats, or what am I not understanding?
Comment 6 Gerrit Notification Bot 2014-07-12 19:35:41 UTC
Change 145785 had a related patch set uploaded by Nikerabbit:
Add UserMerge support

https://gerrit.wikimedia.org/r/145785
Comment 7 Niklas Laxström 2014-07-12 20:14:51 UTC
This is not possible to fix in Translate unless UserMerge gains capability to deduplicate rows.
Comment 8 Gerrit Notification Bot 2014-09-03 22:37:35 UTC
Change 145785 merged by jenkins-bot:
Add UserMerge support

https://gerrit.wikimedia.org/r/145785

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links