Last modified: 2014-11-15 12:19:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69788, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67788 - test2wiki's User:Selenium_user page with redirect and ShortUrl makes Flow browser tests fail
test2wiki's User:Selenium_user page with redirect and ShortUrl makes Flow bro...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-10 05:11 UTC by spage
Modified: 2014-11-15 12:19 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-07-10 05:11:09 UTC
Flow tests on test2wiki have never worked.

I looked at one failure, https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-test2.wikipedia.org-linux-firefox-sauce/lastFailedBuild/#showFailuresLink

The test "Follow user links.User links takes me to the user page"
fails at
  features/post_links.feature:10:in `Then I am on my user page'
Message:
    Sauce Labs job URL: http://saucelabs.com/jobs/6f26f29754884927a682b06035b5e77a
  expected: "User:Selenium user"
     got: "User:SeleniumBot\nhttps://test2.wikipedia.org/s/foc" (using ==)


Sure enough https://test2.wikipedia.org/wiki/User:Selenium_user is a redirect, and the https://www.mediawiki.org/wiki/Extension:ShortUrl is adding a short URL to every page which messes up the test of the username in the title.

1. Can someone get rid of the redirect.
2. Does test2 need to run this extension?  If so, the test for user page title should e.g. target 'h1 > span' so as not to pick up this additional short URL.
Comment 1 This, that and the other (TTO) 2014-07-10 11:28:42 UTC
(In reply to spage from comment #0)
> 1. Can someone get rid of the redirect.

Done. We can blame "User:Block me" for that problem.
Comment 2 Chris McMahon 2014-07-14 16:33:43 UTC
S, thanks for figuring that out.  This should totally use the 'h1 >span' identifier for this
Comment 3 Gerrit Notification Bot 2014-08-21 02:27:23 UTC
Change 155494 had a related patch set uploaded by Spage:
Improve user page title selector for tests

https://gerrit.wikimedia.org/r/155494
Comment 4 Gerrit Notification Bot 2014-08-21 22:42:23 UTC
Change 155494 merged by jenkins-bot:
QA: Improve user page title selector for tests

https://gerrit.wikimedia.org/r/155494
Comment 5 Andre Klapper 2014-10-17 11:41:11 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 6 Andre Klapper 2014-11-15 12:19:00 UTC
No reply to comment 5 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links