Last modified: 2014-11-11 12:54:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69791, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67791 - clear in wbeditentity does not remove claims
clear in wbeditentity does not remove claims
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-07-01
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-10 07:43 UTC by Bene*
Modified: 2014-11-11 12:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bene* 2014-07-10 07:43:57 UTC
When setting clear=true in the wbeditentity api module, all claims still remain in the entity. This happens because of a bug in DataModel which is not trivial to fix. Thus some workaround is needed in the api module itself.
Comment 1 Gerrit Notification Bot 2014-07-10 08:08:39 UTC
Change 145239 had a related patch set uploaded by Bene:
Remove all claims in wbeditentity when clear=true is set

https://gerrit.wikimedia.org/r/145239
Comment 2 Gerrit Notification Bot 2014-07-10 15:32:16 UTC
Change 145239 merged by jenkins-bot:
Remove all claims in wbeditentity when clear=true is set

https://gerrit.wikimedia.org/r/145239
Comment 3 Gerrit Notification Bot 2014-07-10 15:33:02 UTC
Change 145342 had a related patch set uploaded by Hoo man:
Remove all claims in wbeditentity when clear=true is set

https://gerrit.wikimedia.org/r/145342
Comment 4 Gerrit Notification Bot 2014-07-10 16:09:43 UTC
Change 145342 merged by jenkins-bot:
Remove all claims in wbeditentity when clear=true is set

https://gerrit.wikimedia.org/r/145342
Comment 5 Liangent 2014-11-11 12:54:53 UTC
It seems this bug is appearing again:

edit #1: https://www.wikidata.org/w/index.php?title=Q2846039&diff=prev&oldid=173058084
edit #2: https://www.wikidata.org/w/index.php?title=Q2846039&diff=prev&oldid=173058104

My bot sends all wbeditentity calls with clear set.

I'm not quite sure whether my bot sent one or two requests: it retries after the first failure. However there must be some fault on the server side:

If my bot sent one request, having two revision is already abnormal;

If my bot sent two requests, and even if it sent duplicated claims in the second request (which is unlikely by checking my bot's code), but as indicated in edit summary, both have clear set, so no GUID of claims would survive, which should result in an all-removal then double-addition diff (like edit#1), but it's not the case currently.

The only sensible explaination is that the server "forgot" to clear the item, which is this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links