Last modified: 2014-07-21 10:55:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69815, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 67815 - Global blocking race condition


Summary:	Global blocking race condition

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GlobalBlocking (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Kunal Mehta (Legoktm)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-10 18:06 UTC by matanya
Modified:	2014-07-21 10:55 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description matanya 2014-07-10 18:06:19 UTC

when Gblocking:

I got: A database query error has occurred. This may indicate a bug in the software.
    Function: GlobalBlocking::insertBlock
    Error: 1062 Duplicate entry '209.126.72.83-0' for key 'gb_address' (10.64.16.22)

input from IRC:

<legoktm> matanya: yeah race condition, file a bug for it please? :)

<csteipp> It does a check, then does the insert, so definitely a race condition.

Comment 1 Sam Reed (reedy) 2014-07-10 20:21:55 UTC

(In reply to matanya from comment #0)
> <csteipp> It does a check, then does the insert, so definitely a race
> condition.

[19:08:34] <legoktm> well, the check we do before hand uses the slave, not master

Comment 2 Kunal Mehta (Legoktm) 2014-07-10 20:22:55 UTC

Our check to see if there is already a block is currently using a slave. Instead it should be using master.

Then, I'm thinking we should set 'IGNORE' on the insert query, and if we didn't change any rows due to a block already existing, display an error indicating so.

Comment 3 Gerrit Notification Bot 2014-07-11 04:13:45 UTC

Change 145503 had a related patch set uploaded by Legoktm:
Avoid race condition in GlobalBlocking::insertBlock

https://gerrit.wikimedia.org/r/145503

Comment 4 Gerrit Notification Bot 2014-07-11 08:27:26 UTC

Change 145503 merged by jenkins-bot:
Avoid race condition in GlobalBlocking::insertBlock

https://gerrit.wikimedia.org/r/145503

Comment 5 Andre Klapper 2014-07-21 10:54:36 UTC

legoktm: Patches mentioned in this report has been merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Comment 6 Kunal Mehta (Legoktm) 2014-07-21 10:55:27 UTC

This should be fixed now :)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links