Last modified: 2014-07-11 17:43:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69834, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67834 - jenkins - operations-puppet-puppetlint-strict - checks outdated files
jenkins - operations-puppet-puppetlint-strict - checks outdated files
Status: VERIFIED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-11 03:50 UTC by Daniel Zahn
Modified: 2014-07-11 17:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Zahn 2014-07-11 03:50:03 UTC
in operations/puppet i noticed on:

https://gerrit.wikimedia.org/r/#/c/145472/

-->

https://integration.wikimedia.org/ci/job/operations-puppet-puppetlint-strict/4456/console

that jenkins still says all these things about admins.pp, like:

03:42:51 ./manifests/admins.pp:1361 WARNING line has more than 80 characters (80chars)
03:42:51 ./manifests/admins.pp:1371 WARNING line has more than 80 characters (80chars)
03:42:51 ./manifests/admins.pp:1376 WARNING line has more than 80 characters (80chars)

but if you clone the repo and pull, you will see that admins.pp is already empty and doesn't have all these lines anymore, we replaced it with admin yaml

so i guess the file can't be up2date where jenkins checks it, but i have created this patch just today...
Comment 1 Antoine "hashar" Musso (WMF) 2014-07-11 06:17:28 UTC
The first page of manifests/admins.pp is a comment with a bunch of blank line.  Hit page down for the rest of the 3600 lines are so :-]


The awesome vim plugin Powerline ( https://github.com/Lokaltog/powerline ) would give you a colorful status bar with your position in the file and the relative size of the file :-D
Comment 2 Daniel Zahn 2014-07-11 17:43:48 UTC
oh my.. sorry Antoine, of course you're right

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links