Last modified: 2014-07-22 22:44:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69857, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 67857 - Parsoid shouldn't emit empty text nodes as parts of transclusions


Summary:	Parsoid shouldn't emit empty text nodes as parts of transclusions

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal
Target Milestone:	---
Assigned To:	ssastry

URL:	https://nl.wikipedia.org/wiki/Gebruik...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-11 14:52 UTC by Bartosz Dziewoński
Modified:	2014-07-22 22:44 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (44.74 KB, image/png) 2014-07-11 14:52 UTC, Bartosz Dziewoński	Details
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2014-07-11 14:52:10 UTC

Created attachment 15910 [details]
Screenshot

Transclusion dialog shouldn't render empty text nodes.

Example: try modifying any of the table cell templates at https://nl.wikipedia.org/wiki/Gebruiker:Ad_Huikeshoven/jh?uselang=en&veaction=edit#Prestatietabel

The transclusion dialog will show an empty text node at the end. That node can be removed, which results in no changes in wikitext.

(Re-rendering of these table cell templates is broken, by the way, filed separately as bug 67856.)

(Found when playing with bug 67850.)

Comment 1 James Forrester 2014-07-11 18:35:00 UTC

I think this really should be "Parsoid should not emit zero-length content blocks in transclusions", surely?

Comment 2 Gerrit Notification Bot 2014-07-18 21:16:46 UTC

Change 147654 had a related patch set uploaded by Subramanya Sastry:
(Bug 67857): Dont push empty "" in table-fixup code.

https://gerrit.wikimedia.org/r/147654

Comment 3 Gerrit Notification Bot 2014-07-22 16:11:37 UTC

Change 147654 merged by jenkins-bot:
(Bug 67857): Dont push empty "" in table-fixup code.

https://gerrit.wikimedia.org/r/147654

Comment 4 ssastry 2014-07-22 22:44:18 UTC

This will go out tomorrow after rt-testing. please reopen if not fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links