Last modified: 2014-08-05 21:13:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67866 - Gerrit: Auto-linking for urls should not include trailing full stop (breaking urls, 404 Error)
Gerrit: Auto-linking for urls should not include trailing full stop (breaking...
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-11 17:04 UTC by Krinkle
Modified: 2014-08-05 21:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2014-07-11 17:04:07 UTC
It seems Gerrit is consistently including the dot after a url in the url causing loads of links to be broken.

This is hurting development and slowing work down by requiring people to often correct the link after ending up on a 404.

Examples:
 https://gerrit.wikimedia.org/r/#/c/134928/9/i18n/en.json
 https://gerrit.wikimedia.org/r/#/c/145291/7,publish

While this has been happening for a while now, I'm quite sure this wasn't always the case. Think it's a regression from 6-12 months ago.
Comment 1 Andre Klapper 2014-07-11 18:07:43 UTC
I have no idea where exactly the given example links expose the problem.
Comment 2 This, that and the other (TTO) 2014-07-13 12:10:24 UTC
(In reply to Andre Klapper from comment #1)
> I have no idea where exactly the given example links expose the problem.

First one: the link at the end of the first line of the commit message.
Second one: the link in the last comment by Siebrand.

Bugzilla does it right, as you can see from the URL http://example.com/foo.

And yes, this bug is a pain!
Comment 3 Gerrit Notification Bot 2014-07-15 11:21:45 UTC
Change 146425 had a related patch set uploaded by QChris:
Do not linkify trailing dot or comma

https://gerrit.wikimedia.org/r/146425
Comment 4 Gerrit Notification Bot 2014-07-16 17:43:34 UTC
Change 146425 merged by Chad:
Do not linkify trailing dot or comma

https://gerrit.wikimedia.org/r/146425
Comment 5 Tomasz W. Kozlowski 2014-08-05 19:44:18 UTC
Resetting status to "NEW", as both links mentioned in comment 2 are still broken.
Comment 6 christian 2014-08-05 21:13:42 UTC
(In reply to Tomasz W. Kozlowski from comment #5)
> both links mentioned in comment 2 are still
> broken.

Yes, that's expected, as the fix has been merged, but not yet deployed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links