Last modified: 2014-07-11 19:28:49 UTC
Currently, if you review your changes you need to use the "Return to save form" button and then save. Workflow would be improved if the "Review your changes" view had its own save button. Also note than can cannot close the Review view with the escape key, as it closes the complete dialog instead of just the review view.
Oh, that's a neat idea.
This feels like a bad idea – you'd be letting the user press save without showing them what's in the edit summary…
Perhaps the edit summary input box should stay visible, then? I think that would also be useful. I could both wait for the diff to load *and* type the summary at the same time :)
(In reply to Bartosz Dziewoński from comment #3) > Perhaps the edit summary input box should stay visible, then? I think that > would also be useful. I could both wait for the diff to load *and* type the > summary at the same time :) So the idea is that when you click "Review your changes", instead of going to a new page of the dialog, the existing one expands to also show all that information? That sounds like a really confusing design…
@James: see my comment about the escape key: I think the current design is confusing, as the "Review my changes" pages looks a lot like a new dialog but doesn't behave like one.
(In reply to Daniel Naber from comment #5) > @James: see my comment about the escape key: I think the current design is > confusing, as the "Review my changes" pages looks a lot like a new dialog > but doesn't behave like one. We used to have a booklet on the side of this, but that was more confusing. The escape key always closes the current dialog. What do you propose we do to make it clearer that the current dialog is still the same as the previous page?
(In reply to James Forrester from comment #6) > We used to have a booklet on the side of this, but that was more confusing. > The escape key always closes the current dialog. What do you propose we do > to make it clearer that the current dialog is still the same as the previous > page? I'm not sure about mobile and I don't know this old booklet design, but for me there's always enough space to show both the diff and the edit summary at the same time. The edit summary doesn't need four rows anyway I think.
(In reply to James Forrester from comment #2) > This feels like a bad idea – you'd be letting the user press save without > showing them what's in the edit summary… There is currently a “summary preview” at the top of this dialog. I prefer to save when I see the parsed summary than when I see the wikitext one, as it is the one that readers will see.
(In reply to Ltrlg from comment #8) > (In reply to James Forrester from comment #2) > > This feels like a bad idea – you'd be letting the user press save without > > showing them what's in the edit summary… > > There is currently a “summary preview” at the top of this dialog. I prefer > to save when I see the parsed summary than when I see the wikitext one, as > it is the one that readers will see. Fair point. OK, let's do this.
