Last modified: 2014-07-14 03:53:18 UTC
Created attachment 15912 [details] What happens when a link occurs at the edge of the summary To replicate: 1. Go to https://en.wikipedia.org/wiki/2009_K3_League#mediaviewer/File:K3_League_2009.png 2. Set window width to 760px 3. Click the gray ellipsis at the end of the summary. Expected behavior: see the rest of the image summary Current behavior: outbound link to http://www.kfa.or.kr/k_league/k3_league_intro.asp (currently 404) There's no way to show the entire summary field -- if it gets truncated in the middle or beginning of a link, you can end up clicking a link that you don't know its destination, or that it's there at all. Depending on the presence of malware, this could have very bad consequences for an end user. (Mac OS X 10.9/Firefox 30.0) I believe that this and other bugs indicate that Bug 67826 should be implemented instead of set as WONTFIX -- this is yet another bug I found is less than a minute of testing. It's extremely obvious that WMF has pushed out an unfinished and undertested product to one of the top 10 websites worldwide.
If someone adds a malware link to the image description, and the user clicks on it, their browser will go to malware size. Also, if they don't look at the browser-provided URL (typically at the bottom of the window) to see where the link knows, they won't know it (the text of the link is not a reliable indicator of its URL). Neither of these are really related to MediaViewer. As for the ellipsis being a link, Firefox seems to do that if the text is cut off at a link, while in Chrome it is always plain text. We might need to rethink our approach here.
Yeah, the risk isn't that the link exists -- it's that a user won't know it's a link. The proles know that blue text is a link, but won't even look for URLs coming from UI elements, especially so in a JS-heavy application. Perhaps it's an upstream issue for Mozilla. But -- there should still be a way to see all the summary text. I think some element should toggle displaying all the text, since it's obviously loaded already. Make Media Viewer better than what it's replacing, not Real Wiki Lite™.
(In reply to Brent Laabs from comment #2) > Perhaps it's an upstream issue for Mozilla. I think it is. Making the ellipsis the part of the link does make sense, but then it should be styled as such. I see how this can be confusing but it is relatively unlikely to occur. We truncated the text at some number of characters and put a plain-text ellipsis there; the browser-generated ellipsis is only visible on very small screens. Exact truncation without relying on the browser is not easy. (Maybe we could dust off https://gerrit.wikimedia.org/r/#/c/115848/ - $.dotdotdot had problems with multiline fields but it might work well for single-line.) > But -- there should still be a way to see all the summary text. I think > some element should toggle displaying all the text, since it's obviously > loaded already. Make Media Viewer better than what it's replacing, not Real > Wiki Lite™. Indeed; we are working on that. You can see the current thinking in https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/396 and https://gerrit.wikimedia.org/r/144086 .
Filed with Mozilla here: https://bugzilla.mozilla.org/show_bug.cgi?id=1037896 It is unlikely to occur, but I've always had a talent for finding edge cases. I'm glad that there is "current thinking" on this issue, but I guess I'd like to see more implementation than thinking before a feature is forced on a community, contrary to their stated wishes.
Thanks for upstreaming! I don't think this should have been a blocker for deployment. To avoid the Nirvana fallacy, one should compare the cost a feature being imperfect to the cost of not having it at all, not some imaginary scenario where it would have been made perfect in the same amount of time. I think Media Viewer is still a major net win; reasonable people can disagree but I am pretty sure this is not the bug that would tip the scales for them :)
