Last modified: 2014-07-25 20:45:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69906, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 67906 - Fix how tours are conditionally defined/started


Summary:	Fix how tours are conditionally defined/started

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GuidedTour (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-12 00:39 UTC by Matthew Flaschen
Modified:	2014-07-25 20:45 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-07-12 00:39:27 UTC

Visiting the GettingStarted tours directly (not how they are normally served) throws an error, due to how the tour definition is aborted.

We should have an architectural discussion to finally solve this issue properly.

## Issues
* `TypeError: Cannot read property 'showConditionally' of undefined`

Probably the same issue:
* Uncaught TypeError: Cannot read property 'getStep' of undefined from https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/ee1cc5abb890c000b16cd12f0cc8d2f8eaa65c25/modules%2Fext.guidedTour.lib%2Fext.guidedTour.lib.main.js#L240

The GettingStarted tours are one symptom, but this is a general issue.

Comment 1 Matthew Flaschen 2014-07-25 20:45:45 UTC

See also comments at https://gerrit.wikimedia.org/r/#/c/84735/ .

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links