Last modified: 2014-10-03 12:32:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T69946, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 67946 - accessKeyLabel not available in Firefox for addPortletLink
accessKeyLabel not available in Firefox for addPortletLink
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.24rc
All All
: Low minor (vote)
: 1.25.0 release
Assigned To: Fomafix
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-13 12:07 UTC by Fomafix
Modified: 2014-10-03 12:32 UTC (History)
3 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fomafix 2014-07-13 12:07:03 UTC
Firefox supports localized access key labels but only when the element is appended to the DOM tree:

$('<span>').attr('accesskey', 'g').appendTo('body')[0].accessKeyLabel
--> "Alt+Umschalt+g"

$('<span>').attr('accesskey', 'g')[0].accessKeyLabel
--> ""

mw.util.addPortletLink() calls updateTooltipAccessKeys() before appending to DOM tree, so the tooltip for the access key label is not localized:

mw.util.addPortletLink( 'p-views', '#', 'Foo', 't-foo', 'Foo tooltip', 'g' );
--> Tooltip is "Foo tooltip [alt-shift-g]".

Expected result:
--> Tooltip is "Foo tooltip [Alt+Umschalt-g]". (On a German Firefox)
Comment 1 Gerrit Notification Bot 2014-07-13 12:13:55 UTC
Change 145889 had a related patch set uploaded by Gerrit Patch Uploader:
Get localized access key tooltip mw.util.addPortletLink()

https://gerrit.wikimedia.org/r/145889
Comment 2 Krinkle 2014-07-19 21:08:52 UTC
Upstream bug report:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1037990
Comment 3 Gerrit Notification Bot 2014-09-14 21:27:24 UTC
Change 160300 had a related patch set uploaded by Gerrit Patch Uploader:
jquery.accessKeyLabel: Append element into DOM on empty accessKeyLabel

https://gerrit.wikimedia.org/r/160300
Comment 4 Gerrit Notification Bot 2014-10-03 11:56:25 UTC
Change 145889 merged by jenkins-bot:
mediawiki.util: Insert node before updating tooltip for accesskey

https://gerrit.wikimedia.org/r/145889
Comment 5 Bartosz Dziewoński 2014-10-03 12:32:01 UTC
As I understand it this issue is fixed, with the jquery.accessKeyLabel patch being a more generic solution.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links