Last modified: 2014-09-16 17:56:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70079, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68079 - VisualEditor: Re-use an existing reference shouldn't require a reference list to be or have been on the page to work
VisualEditor: Re-use an existing reference shouldn't require a reference list...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-07-31
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-15 23:21 UTC by Ritu Swain
Modified: 2014-09-16 17:56 UTC (History)
7 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Script error for each citation (86.94 KB, image/png)
2014-07-15 23:21 UTC, Ritu Swain
Details

Description Ritu Swain 2014-07-15 23:21:10 UTC
Created attachment 15949 [details]
Script error for each citation

Test Environment-test2
Steps to Reproduce-

Scenario#1-
1> Select the ” Cite “ drop down and add a Journal, News, Book,  one of each citations.
2> Now click on “Insert” and select “Media”. Click on any picture returned in the dialog(do not enter any search term)
3> In the Media Settings dialog click on “Insert” again and select “Media” from the Caption toolbar. Click on any picture returned in the dialog.
4> Now close all the dialogs. 
5> Repeat again steps #2,3 and 4.
6>In the main VE window  click on “Cite”  and select “Basic”. Reference dialog opens.
5> In the Reference dialog select “Use an existing reference”.
6> Script Error is shown as existing reference.

Scenario#2-
1> Go to the Media Settings dialog. 
2> While General Settings is highlighted, select the ” Cite “ drop down and add a Journal, News, Book,  one of each citations to the Caption pane.
3> Now click on “Insert “dropdown and select “Media”.
4>Click on any picture in the media search dialog. Media Settings dialog pops. Close this dialog.
5> Repeat steps 3 and 4 again.
5> Notice that the previously opened Media Settings dialog is still open with the citations in the Caption pane.
6> Click on “Cite” again and select “Basic”. Reference dialog opens.
7> In the Reference dialog select “Use an existing reference”.
8> Script Error is shown as existing reference.
Comment 1 James Forrester 2014-07-16 16:05:43 UTC
(In reply to Ritu Swain from comment #0)
> Created attachment 15949 [details]
> Script error for each citation
> 
> Test Environment-test2
> Steps to Reproduce-
> 
> Scenario#1-
> 1> Select the ” Cite “ drop down and add a Journal, News, Book,  one of each
> citations.
> 2> Now click on “Insert” and select “Media”. Click on any picture returned
> in the dialog(do not enter any search term)
> 3> In the Media Settings dialog click on “Insert” again and select “Media”
> from the Caption toolbar. Click on any picture returned in the dialog.
> 4> Now close all the dialogs. 
> 5> Repeat again steps #2,3 and 4.
> 6>In the main VE window  click on “Cite”  and select “Basic”. Reference
> dialog opens.
> 5> In the Reference dialog select “Use an existing reference”.
> 6> Script Error is shown as existing reference.

The problem here is the "re-use existing reference" code seems to rely on there being a reference list on the page (or there having been one at some point in this edit?) – if there's no reference list yet, it shows the references as blank or with a Lua script error. Is this something as simple as populating the internal list as needed?
Comment 2 Rummana Yasmeen 2014-07-16 19:26:28 UTC
This bugs is found in test2 so the reason why it is showing script error for the Cite News,Cite Journal,Cite Book but not Cite Web, the template data for those options are not defined in test2.
So if you just add those Cite Options and add a reflist , you will also see script errors in the reference list.


However there is one issue here, when you first time add any reference, and open use existing reference dialog, the reference name will not appear but after that if you do any other action like adding a media, or a link or a reflist it appears.
Comment 3 Alex Monk 2014-07-31 01:16:08 UTC
(In reply to Rummana Yasmeen from comment #2)
> However there is one issue here, when you first time add any reference, and
> open use existing reference dialog, the reference name will not appear but
> after that if you do any other action like adding a media, or a link or a
> reflist it appears.

That sounds like bug 67342. Is this valid?
Comment 4 James Forrester 2014-07-31 01:42:41 UTC
This looks like it's now fixed.

(Note that the "re-use" list can take a few seconds to update, so if you've just created a cite it may render as "[4]" rather than "[4] Foo. Bar (Baz)" which will happen later if you wait.

Thanks, Krenair!
Comment 5 Ritu Swain 2014-08-01 19:43:14 UTC
Issue Resolved in test2.
Comment 6 Rummana Yasmeen 2014-08-05 18:28:03 UTC
The delay to load citations in RE-Use dialog is pretty noticeable now.Previously,it was not like that.Is it an effect of this fix?
Comment 7 Alex Monk 2014-08-06 11:16:03 UTC
Probably an effect of whatever caused this?
Comment 8 Rummana Yasmeen 2014-08-06 18:39:06 UTC
okay, so there is no need to have a new bug on it I guess.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links