Last modified: 2014-07-25 18:48:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70121, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68121 - VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from the tab in toolbar , selecting "Discard Changes" redirects to the Edit source mode of the main page


Summary:	VisualEditor:[Regression pre-wmf14] While switching to Edit source mode from ...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	MediaWiki integration (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-07-17
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-07-16 21:08 UTC by Rummana Yasmeen
Modified:	2014-07-25 18:48 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (172.27 KB, image/png) 2014-07-16 21:08 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-07-16 21:08:50 UTC

Created attachment 15952 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Edit the page
3.Now click on the "Edit Source" tab
4.Click on the option "Discard Changes"

Observed Result:
It redirects to the edit source mode of the main page .

See the screenshot attached.

Comment 1 Rummana Yasmeen 2014-07-16 21:11:45 UTC

It happens also if I switch to Edit Source mode from the Switch to Source Editing option.

Comment 2 James Forrester 2014-07-16 21:43:10 UTC

This is a fun one. Are we passing '' to the API instead of the page name?

Comment 3 Gerrit Notification Bot 2014-07-16 22:16:54 UTC

Change 146956 had a related patch set uploaded by Alex Monk:
Set title of page to use if discarding changes when changing to the wikitext editor

https://gerrit.wikimedia.org/r/146956

Comment 4 Gerrit Notification Bot 2014-07-17 00:09:00 UTC

Change 146956 merged by jenkins-bot:
Set title of page to use if discarding changes when changing to the wikitext editor

https://gerrit.wikimedia.org/r/146956

Comment 5 Rummana Yasmeen 2014-07-18 22:00:20 UTC

Verified the fix in test2

Comment 6 Stryn 2014-07-21 17:17:59 UTC

It still redirects to the main page, if you choose some version from the history page and then do the same.

1) https://en.wikipedia.org/w/index.php?title=Test&oldid=614834396
2) click edit
3) (make some changes to the page)
4) switch to source editing
5) discard changes
and you're again editing the main page

Comment 7 Alex Monk 2014-07-21 17:33:45 UTC

Are you sure that wiki is running a version of VisualEditor with the fix for this bug? I'm pretty sure Wikipedia is supposed to get this change is on Thursday...

Comment 8 Stryn 2014-07-21 17:37:45 UTC

(In reply to Alex Monk from comment #7)
> Are you sure that wiki is running a version of VisualEditor with the fix for
> this bug? I'm pretty sure Wikipedia is supposed to get this change is on
> Thursday...

I see. I thought it was already deployed to all wikis. Sorry.

Comment 9 Alex Monk 2014-07-21 17:41:54 UTC

https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap is a useful reference for Wikimedia deployments

Comment 10 Rummana Yasmeen 2014-07-25 18:48:15 UTC

Verified the fix in production en.wiki

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links