Last modified: 2014-07-27 17:24:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70143, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 68143 - Enter should submit user login form instead of GoogleLogin


Summary:	Enter should submit user login form instead of GoogleLogin

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GoogleLogin (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy

Depends on:	68097
Blocks:
	Show dependency tree / graph

Reported:	2014-07-17 08:23 UTC by Florian
Modified:	2014-07-27 17:24 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-07-17 08:23:11 UTC

When the user hit enter to send his login data on the login form in a wiki using GoogleLogin, he will  be redirected to the GoogleLogin authentication prompt, if the login data was incorrectm, instead of show the "login failed" screen.

-> Check in AuthPlugin, if username and password is set, and if so, don't use GoogleLogin.

Comment 1 Gerrit Notification Bot 2014-07-26 18:13:57 UTC

Change 149540 had a related patch set uploaded by Florianschmidtwelzow:
Don't redirect to Google auth if user hit enter

https://gerrit.wikimedia.org/r/149540

Comment 2 Gerrit Notification Bot 2014-07-27 16:58:57 UTC

Change 149540 merged by jenkins-bot:
Don't redirect to Google auth if user hit enter

https://gerrit.wikimedia.org/r/149540

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links