Last modified: 2014-07-22 21:20:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70188, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 68188 - core mediawiki.util test failing in Flow qunit Jenkins jobs
core mediawiki.util test failing in Flow qunit Jenkins jobs
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-17 20:14 UTC by Jon
Modified: 2014-07-22 21:20 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-07-17 20:14:28 UTC
It's not clear why.
Can anyone shed light on why this happen?:
https://integration.wikimedia.org/ci/job/mwext-Flow-qunit/318/console
Comment 1 Željko Filipin 2014-07-18 09:00:19 UTC
Changing component to CI, I do not think QA team can help here.
Comment 2 Greg Grossmeier 2014-07-19 05:25:58 UTC
This looks to be the consistent warning/failure in the console log:

00:44:56 >> Message: Died on test #2     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=ext.flow.new.handlebars.tests%7Cext.flow.new.tests%7Cext.mantle%7Cext.mantle.handlebars%2Cmodules%2Coo%2Ctemplates%2Cviews%7Cext.mantle.oo.tests%7Cext.mantle.templates.tests%7Cext.mantle.views.tests%7Cjquery.accessKeyLabel%2CcheckboxShiftClick%2Cclient%2CgetAttrs%2Cjson%2CmakeCollapsible%2Cmw-jump%2CmwExtension%2Cplaceholder%2Cqunit%2CtabIndex%2Cthrottle-debounce%7Cjquery.qunit.completenessTest%7Cmediawiki.cldr%2CjqueryMsg%2Clanguage%2Cnotify%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.legacy.ajax%2Cwikibits%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.special.javaScriptTest%7Cskins.vector.js%7Ctest.mediawiki.qunit.testrunner%7Ctest.sinonjs&skin=vector&version=20140719T004439Z&*:107
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery.autoEllipsis%2CbyteLength%2CbyteLimit%2Ccolor%2CcolorUtil%2Ccookie%2Chidpi%2ChighlightText%2Clocalize%2Csuggestions%2Ctablesorter%2CtextSelection%7Cmediawiki.Title%2CUri%2Capi%2Ccookie%2Chidpi%2CsearchSuggest%2Cspecial%2Ctoc%2Cuser%7Cmediawiki.api.category%2Cparse%2Cwatch%7Cmediawiki.language.months%7Cmediawiki.special.recentchanges%7Ctest.mediawiki.qunit.suites&skin=vector&version=20140719T004439Z&*:274
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery.autoEllipsis%2CbyteLength%2CbyteLimit%2Ccolor%2CcolorUtil%2Ccookie%2Chidpi%2ChighlightText%2Clocalize%2Csuggestions%2Ctablesorter%2CtextSelection%7Cmediawiki.Title%2CUri%2Capi%2Ccookie%2Chidpi%2CsearchSuggest%2Cspecial%2Ctoc%2Cuser%7Cmediawiki.api.category%2Cparse%2Cwatch%7Cmediawiki.language.months%7Cmediawiki.special.recentchanges%7Ctest.mediawiki.qunit.suites&skin=vector&version=20140719T004439Z&*:301
00:44:56 >>     at runScript (http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:171)
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:171
00:44:56 >>     at execute (http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:172)
00:44:56 >>     at handlePending (http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:169)
00:44:56 >>     at runScript (http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:171)
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:171
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:171
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:44
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:46
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:46
00:44:56 >>     at addEmbeddedCSS (http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:166)
00:44:56 >>     at http://localhost:9412/jenkins-mwext-Flow-qunit-380/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20140719T004439Z:166: 'null' is not an object (evaluating 'mw.util.$content.length')
00:44:56 >> TypeError: 'null' is not an object (evaluating 'mw.util.$content.length')

(copied from: https://integration.wikimedia.org/ci/job/mwext-Flow-qunit/380/console )
Comment 3 Jon 2014-07-21 18:24:19 UTC
Correct.. but the test it refers to is a core test that Flow shouldn't be interfering with.

Does anyone know why we might be getting this issue? I just can't for the life of me work it out (it passes fine locally)

Are we absolutely 100% sure it's not related to Jenkins?
Comment 4 Antoine "hashar" Musso (WMF) 2014-07-21 18:57:36 UTC
Jon, it might be a regression in mw/core or Flow badly interacting with that specific case.  A way to reproduce would be to have a fresh mediawiki + Flow installed then run the Qunit test to see if you can reproduce it on a local install.

https://www.mediawiki.org/wiki/Qunit has some documentation.


I think Matt Flaschen (added to cc) had a similar issue.  If all fail, fallback to our Javascript guru Timo :)
Comment 5 Jon 2014-07-21 20:25:38 UTC
Okay I can replicate this now. Thanks for the hint :)
Comment 6 Gerrit Notification Bot 2014-07-21 20:28:21 UTC
Change 148220 had a related patch set uploaded by Jdlrobson:
Get QUnit tests passing in Jenkins

https://gerrit.wikimedia.org/r/148220
Comment 7 Jon 2014-07-21 20:29:34 UTC
@hashar looks like Jenkins wasn't showing another error that was being thrown.
I've fixed the issue (missing module dependency)

Would be great if you could make Jenkins QUnit jobs voting for Flow now! :) With this patch they pass! \o/
Comment 8 Greg Grossmeier 2014-07-21 20:32:11 UTC
(In reply to Jon from comment #7)
> @hashar looks like Jenkins wasn't showing another error that was being
> thrown.
> I've fixed the issue (missing module dependency)
> 
> Would be great if you could make Jenkins QUnit jobs voting for Flow now! :)
> With this patch they pass! \o/

YAY
Comment 9 Antoine "hashar" Musso (WMF) 2014-07-21 20:35:23 UTC
(In reply to Jon from comment #7)
> @hashar looks like Jenkins wasn't showing another error that was being
> thrown.
> I've fixed the issue (missing module dependency)
> 
> Would be great if you could make Jenkins QUnit jobs voting for Flow now! :)
> With this patch they pass! \o/

@jon Making qunit voting is bug 67734 =)
Comment 10 Gerrit Notification Bot 2014-07-22 01:09:51 UTC
Change 148220 merged by jenkins-bot:
Get QUnit tests passing in Jenkins

https://gerrit.wikimedia.org/r/148220
Comment 11 Gerrit Notification Bot 2014-07-22 20:37:10 UTC
Change 148454 had a related patch set uploaded by EBernhardson:
Get QUnit tests passing in Jenkins

https://gerrit.wikimedia.org/r/148454
Comment 12 Gerrit Notification Bot 2014-07-22 20:39:12 UTC
Change 148454 merged by jenkins-bot:
Get QUnit tests passing in Jenkins

https://gerrit.wikimedia.org/r/148454

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links